-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #26: Fix splices in requires clause #86
Issue #26: Fix splices in requires clause #86
Conversation
Signed-off-by: delimbetov <1starfall1@gmail.com>
Signed-off-by: delimbetov <1starfall1@gmail.com>
Signed-off-by: delimbetov <1starfall1@gmail.com>
Signed-off-by: delimbetov <1starfall1@gmail.com>
Signed-off-by: delimbetov <1starfall1@gmail.com>
Signed-off-by: delimbetov <1starfall1@gmail.com> # Conflicts: # P2996.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks amazing! Two very minor comment nits, and we're good to go.
static_assert(nested_addable2<Addable>); | ||
static_assert(!nested_addable2<NonAddable>); | ||
|
||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit:
} // namespace requires_clause
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Signed-off-by: delimbetov <1starfall1@gmail.com>
Issue number of the reported bug or feature request: #26
Describe your changes
Fixed parsing of splices in requires clauses
Testing performed
Added tests for the 4 requirements types: simple, type, compound and nested.