Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend DNS resolver to include TCP and HTTP checks for external targets #115

Merged
merged 3 commits into from
Aug 26, 2022

Conversation

kitfoman
Copy link
Contributor

@kitfoman kitfoman commented Mar 4, 2022

Goldpinger can currently do DNS checks via HOSTS_TO_RESOLVE. This aims to extend that functionality so it can also do L4/L7 tcp and http/s checks.

Breaking Changes

Timeout types were changed from int64 to time.Duration in the configuration here.
The flags ping-timeout-ms, check-timeout-ms and check-all-timeout-ms were also changed accordingly.

Backward compatibility was considered but there doesn't seem to be a nice way of accomplishing this.

@kitfoman kitfoman force-pushed the add-external-probes branch 6 times, most recently from 0b7bf0f to 26bfd31 Compare March 4, 2022 16:24
@seeker89
Copy link
Contributor

Hey @kitfoman - sorry for the delay, I finally got around to looking at this.

It's great, but I'm a little bit concerned about the backwards compatibility. How would you feel about keeping the old flags with -ms postfix for now, marking them as deprecated, and using those, unless the new ones (duration) are used?

Ideally we wouldn't break anyone.

The other thing I'm wondering is how to best reflect the new probes in the prometheus metrics.

@kitfoman
Copy link
Contributor Author

Hey @seeker89 I just saw this.

It's great, but I'm a little bit concerned about the backwards compatibility. How would you feel about keeping the old flags with -ms postfix for now, marking them as deprecated, and using those, unless the new ones (duration) are used?

That sounds reasonable to me. I'll make those changes.

The other thing I'm wondering is how to best reflect the new probes in the prometheus metrics.

Do you mean in addition to these? We can include a histogram as well if we want to expose latency information. Is there anything else that would be useful?

@kitfoman
Copy link
Contributor Author

It's great, but I'm a little bit concerned about the backwards compatibility. How would you feel about keeping the old flags with -ms postfix for now, marking them as deprecated, and using those, unless the new ones (duration) are used?

@seeker89 does this seem okay? https://github.com/kitfoman/goldpinger/blob/add-external-probes/cmd/goldpinger/main.go#L147

@seeker89
Copy link
Contributor

It's great, but I'm a little bit concerned about the backwards compatibility. How would you feel about keeping the old flags with -ms postfix for now, marking them as deprecated, and using those, unless the new ones (duration) are used?

@seeker89 does this seem okay? https://github.com/kitfoman/goldpinger/blob/add-external-probes/cmd/goldpinger/main.go#L147

Yup, that's what I was thinking.

@seeker89
Copy link
Contributor

Looks like the DCO bot is unhappy again - would you mind re-pushing with -s?

@seeker89
Copy link
Contributor

seeker89 commented May 6, 2022

Hey, 69708ba is still missing the -s...

tyler-lloyd and others added 2 commits May 8, 2022 22:02
only check node IPs when determining hostIP

IP_VERSIONS not IP_FAMILIES

Signed-off-by: Tyler Lloyd <tyler.lloyd@microsoft.com>
Signed-off-by: kitfoman <thaddeusgetachew@gmail.com>

make timeout flags backwards compatible

Signed-off-by: kitfoman <thaddeusgetachew@gmail.com>
@kitfoman
Copy link
Contributor Author

kitfoman commented May 9, 2022

Hey, 69708ba is still missing the -s...

sorry I confused myself there. It should be good now

@ArjonBu
Copy link

ArjonBu commented Aug 24, 2022

Is this going to be merged?

@seeker89 seeker89 merged commit 8ad0802 into bloomberg:master Aug 26, 2022
@ArjonBu
Copy link

ArjonBu commented Aug 29, 2022

@seeker89 The new version hasn't been pushed yet to docker hub. Is it planned?

@kitfoman
Copy link
Contributor Author

kitfoman commented Aug 29, 2022

@seeker89 The new version hasn't been pushed yet to docker hub. Is it planned?

@ArjonBu No there was a compile time error that I somehow missed and caused the CI build to fail. Created a new PR to address this #121

@seeker89
Copy link
Contributor

Pushed v3.6.1 just now - not sure how the CI didn’t fail before, but here it goes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants