Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: Rename template to generate and move rebase/upgrade under switch #116

Merged
merged 20 commits into from
May 27, 2024
Merged

refactor!: Rename template to generate and move rebase/upgrade under switch #116

merged 20 commits into from
May 27, 2024

Conversation

gmpinder
Copy link
Member

@gmpinder gmpinder commented Mar 6, 2024 •
edited
Loading

This updates the template subcommand to be generate. The template usage will continue to work as an alias to generate. A new switch command is added that will manage both rpm-ostree rebase and rpm-ostree upgrade and is fully replacing the respective subcommands as a breaking change.

The new switch command is under the feature flag switch and will currently only build for the main branch builds until it is moved as a default feature (v0.9.0).

Closes #159

@gmpinder gmpinder linked an issue Mar 6, 2024 that may be closed by this pull request
refactor!: commandline interface design discussion #65
Closed
@gmpinder gmpinder marked this pull request as draft March 6, 2024 23:22
@gmpinder
Copy link
Member Author

gmpinder commented Mar 6, 2024

Still need to add logic to auto-determine rpm-ostree command and update the README to match these changes.

@gmpinder gmpinder added this to the v0.9.0 milestone Mar 19, 2024
@gmpinder gmpinder mentioned this pull request Apr 12, 2024
Closed
@gmpinder gmpinder added type: feature Brand new functionality, features, pages, workflows, endpoints, etc. breaking Introduces a breaking change. labels Apr 12, 2024
@gmpinder gmpinder self-assigned this Apr 20, 2024
@gmpinder gmpinder changed the title refactor!: Rename template to generate and move rebase/upgrade under build --switch refactor!: Rename template to generate and move rebase/upgrade under switch May 23, 2024
@gmpinder gmpinder marked this pull request as ready for review May 26, 2024 23:46
@gmpinder gmpinder enabled auto-merge (squash) May 26, 2024 23:46
fiftydinar
fiftydinar approved these changes May 27, 2024
View reviewed changes
Copy link
Contributor

@fiftydinar fiftydinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my limited understanding

@gmpinder gmpinder disabled auto-merge May 27, 2024 02:47
@gmpinder gmpinder merged commit 02b2fe5 into main May 27, 2024
4 checks passed
@gmpinder gmpinder deleted the 65-refactor-commandline-interface-design-discussion branch May 27, 2024 02:47
@gmpinder gmpinder mentioned this pull request Nov 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fiftydinar fiftydinar fiftydinar approved these changes

@bayou-brogrammer bayou-brogrammer Awaiting requested review from bayou-brogrammer

@xynydev xynydev Awaiting requested review from xynydev

@gerblesh gerblesh Awaiting requested review from gerblesh

Assignees

@gmpinder gmpinder

Labels
breaking Introduces a breaking change. type: feature Brand new functionality, features, pages, workflows, endpoints, etc.
Projects
None yet
Milestone
v0.9.0
2 participants
@gmpinder @fiftydinar