Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add MODULE_DIRECTORY env var #142

Merged
merged 1 commit into from
Mar 29, 2024
Merged

chore: add MODULE_DIRECTORY env var #142

merged 1 commit into from
Mar 29, 2024

Conversation

xynydev
Copy link
Member

@xynydev xynydev commented Mar 29, 2024

This exists in the legacy template:
https://github.com/blue-build/legacy-template/blob/489ebea77b79bd722679352bf8c75f185562e3b6/build.sh#L13C1-L13C39

And is also used in many modules, though with MODULE_DIRECTORY="${MODULE_DIRECTORY:-"/tmp/modules"}" to not break things.

And is documented on the website, because I assumed it existed: https://blue-build.org/reference/module/#module_directory

I know this probably won't change much, but it's still useful for the scripts.

This exists in the legacy template:
https://github.com/blue-build/legacy-template/blob/489ebea77b79bd722679352bf8c75f185562e3b6/build.sh#L13C1-L13C39

And is also used in many modules, though with `MODULE_DIRECTORY="${MODULE_DIRECTORY:-"/tmp/modules"}"` to not break things.

And is documented on the website, because I assumed it existed:
https://blue-build.org/reference/module/#module_directory

I know this probably won't change much, but it's still useful for the scripts.
@xynydev xynydev requested a review from gmpinder as a code owner March 29, 2024 11:14
@gmpinder gmpinder merged commit fcc012b into main Mar 29, 2024
3 checks passed
@gmpinder gmpinder deleted the module_directory branch March 29, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants