Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: moving component files to the new, standardized location #70

Merged
merged 3 commits into from
May 10, 2023

Conversation

Arcitec
Copy link

@Arcitec Arcitec commented May 10, 2023

This is a work in progress.

I did this now since bikeshedding is boring and many eyes have been on the proposal with zero interjections, so to get the ball rolling, here's the first pull request.

Ready for merge.

The following files are now corrected:

/usr/share/ublue-os/
  ├── firstboot
zz│   │── ublue-firstboot.desktop
x │   └── yafti.yml
x │── just
x │   └── justfile
yy│── update-services
yy│   └── etc
yy│       └── rpm-ostreed.conf
x └── recipe.yml
  • x = done
  • zz = depends on a larger improvement to the first-boot system, will be done in a separate pull request after this is merged
  • yy = needs doing in other repo (that fix belongs to "main")

@Arcitec Arcitec requested a review from castrojo as a code owner May 10, 2023 16:43
@Arcitec Arcitec marked this pull request as draft May 10, 2023 16:43
@Arcitec Arcitec changed the title fix: moving component files to the new, standardized location fix!: moving component files to the new, standardized location May 10, 2023
@Arcitec Arcitec marked this pull request as ready for review May 10, 2023 17:07
@xynydev
Copy link
Member

xynydev commented May 10, 2023

Copy link
Member

@xynydev xynydev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, move justfile to /usr/share/ublue-os/just/justfile

@Arcitec Arcitec force-pushed the universal-config branch from badadba to abc963c Compare May 10, 2023 18:09
@Arcitec Arcitec force-pushed the universal-config branch from abc963c to a74328b Compare May 10, 2023 18:32
@Arcitec
Copy link
Author

Arcitec commented May 10, 2023

As discussed, move justfile to /usr/share/ublue-os/just/justfile

Yep, already did that change. :)

Just finished rebasing it onto main. It's ready.

@xynydev xynydev merged commit 8ee9967 into blue-build:main May 10, 2023
@Arcitec
Copy link
Author

Arcitec commented May 10, 2023

@EinoHR Regarding ublue-firstboot, I will work on that tomorrow evening (sometime after 18:00 GMT). It's going to be a larger change to how that's executed. I need to rest today since I have an important appointment tomorrow. :) But that will soon be fixed too. Then the startingpoint repo will be fully transitioned to the new storage location.

@Arcitec Arcitec deleted the universal-config branch May 11, 2023 14:11
b- pushed a commit to briorg/server that referenced this pull request Oct 13, 2023
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants