Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Move recipe.yml into ./recipes to support proper caching #27

Merged
merged 5 commits into from
May 1, 2024

Conversation

gmpinder
Copy link
Member

Requires blue-build/github-action#39 to be merged and released.

@gmpinder gmpinder added the type: chore Converting measurements, reorganizing folder structure, and less impactful tasks. label Apr 25, 2024
@gmpinder gmpinder self-assigned this Apr 25, 2024
@gmpinder gmpinder marked this pull request as draft April 25, 2024 00:51
@xynydev
Copy link
Member

xynydev commented Apr 26, 2024

The recipe in the template shouldn't be moved before modules are changed to support the move.

@gmpinder
Copy link
Member Author

The recipe in the template shouldn't be moved before modules are changed to support the move.

The recipe move is completely separate functionality from the config to files move so this works perfectly fine.

@fiftydinar
Copy link
Collaborator

I'm in for this change as it doesn't break anything & it solves the big update sizes that users were complaining about.

Migration from ./config to ./files & ./containerfiles can come later, as it's mostly just a cosmetic improvement in structure.

So, the only question that remains is:

  • Should we bump GitHub Action to v1.4.0 now with this fix, or wait for ./config refactor in bash modules to complete?

@xynydev
Copy link
Member

xynydev commented Apr 26, 2024

I think it would be better to roll out all changes at once, with an announcement post to document it, and the config/ folder being entirely retired. I wouldn't make an undocumented config the default in the template. We can of course still instruct people to move their recipe file, if they have issues with the update sizes.

@gmpinder
Copy link
Member Author

I think it would be better to roll out all changes at once, with an announcement post to document it, and the config/ folder being entirely retired. I wouldn't make an undocumented config the default in the template. We can of course still instruct people to move their recipe file, if they have issues with the update sizes.

If that's the case then I don't think we should release the GHA with the cache feature until we have the recipe directory be the default in the template. Releasing a cache focused update to the action without having the default setup make use of it seems counter-intuitive to me. This is something that can be done incrementally and without large sweeping changes that would give immediate benefit to new users.

@gmpinder gmpinder marked this pull request as ready for review May 1, 2024 20:20
@gmpinder gmpinder merged commit 32ef7f1 into main May 1, 2024
2 checks passed
@gmpinder gmpinder deleted the new-recipe-location branch May 1, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: chore Converting measurements, reorganizing folder structure, and less impactful tasks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants