Use latest bokeh version #757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't use
CustomJS.from_py_funcanymore so can use the latest bokeh version.Note that the Python Bokeh and BokehJS versions need to match and they are currently both set to the latest. We therefore now switch from https://www.npmjs.com/package/bokehjs to https://www.npmjs.com/package/@bokeh/bokehjs.
Note that a simple
import embed from "@bokeh/bokehjs";orimport * as Bokeh from "@bokeh/bokehjs";did not work, resulting in errors when building the Angular app. I found this workaroundimport * as Bokeh from '@bokeh/bokehjs/build/js/lib/embed';here.Also note that bokeh v2.0 requires Python 3.6 as mentioned in #133, so this effectively makes Python 3.6 a requirement for GridPath. [The Windows UI issue that required Python 3.5 or lower if using the Anaconda Python distribution has been resolved, but is yet to be documented: to get the UI to working with Python 3.6+ on Windows, we also need to add an environment variable to the PATH pointing to the Anaconda Library\bin directory (for me that's C:\ProgramData\Anaconda3\Library\bin)].