Support TLS environment variables #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmilyEmily
reviewed
Dec 23, 2019
zhanggbj
approved these changes
Dec 23, 2019
| // // DefaultTLSVerify is the default value for HELM_TLS_VERIFY | ||
| // DefaultTLSVerify = false | ||
| //) | ||
|
|
There was a problem hiding this comment.
If not used, please help to remove commented code, thx!
mattcui
force-pushed
the
env-tls
branch
2 times, most recently
from
49d29a1 to
cc13937
Compare
@EmilyEmily I made a new install-binary.sh, please review. |
EmilyEmily
reviewed
Dec 24, 2019
Comment on lines
+28
to
+31
| armv5*) ARCH="armv5";; | ||
| armv6*) ARCH="armv6";; | ||
| armv7*) ARCH="armv7";; | ||
| aarch64) ARCH="arm64";; |
There was a problem hiding this comment.
Can these be in the else branch? Because we only support two ARCH: amd64 and i386.
install-binary.sh
Outdated
| msys*) OS='windows';; | ||
| # Minimalist GNU for Windows | ||
| mingw*) OS='windows';; | ||
| darwin) OS='darwin';; |
EmilyEmily
approved these changes
Dec 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.