forked from chromium/chromium
-
-
Notifications
You must be signed in to change notification settings - Fork 17
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Better expose PDFiumEngine::plugin_size() callers that fail DCHECK
Use DUMP_WILL_BE_NOTREACHED() in PDFiumEngine::plugin_size() instead of a DCHECK(), so that the DCHECK() failures consistently generate non-fatal dumped in all builds. Temporarily un-inline plugin_size() to avoid putting more code into the header. Bug: 40193305 Change-Id: I92459e6d36fe33d296404486dd4b93615113a719 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5618930 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by: Alan Screen <awscreen@chromium.org> Cr-Commit-Position: refs/heads/main@{#1313170}
- Loading branch information
Showing
2 changed files
with
10 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters