Skip to content

Commit

Permalink
Added new strings for reader mode action chip
Browse files Browse the repository at this point in the history
Bug: 1373898, 1375828
Change-Id: I79df365397b41357fd24eedee0ad01bb1952a51c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3950990
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Commit-Queue: Salvador Guerrero Ramos <salg@google.com>
Cr-Commit-Position: refs/heads/main@{#1060166}
  • Loading branch information
Salvador Guerrero authored and Chromium LUCI CQ committed Oct 17, 2022
1 parent a28d76e commit c38a889
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ public class ReaderModeToolbarButtonController extends BaseButtonDataProvider {
public ReaderModeToolbarButtonController(Supplier<Tab> activeTabSupplier,
ModalDialogManager modalDialogManager, Drawable buttonDrawable) {
super(activeTabSupplier, modalDialogManager, buttonDrawable, R.string.reader_view_text_alt,
/* contentDescriptionResId= */ R.string.reader_mode_message_title,
/* actionChipLabelResId= */ R.string.reader_mode_action_chip_label_simplify_page,
/* supportsTinting= */ true, /* iphCommandBuilder= */ null,
AdaptiveToolbarButtonVariant.READER_MODE);
}
Expand Down
3 changes: 3 additions & 0 deletions chrome/browser/ui/android/strings/android_chrome_strings.grd
Original file line number Diff line number Diff line change
Expand Up @@ -3835,6 +3835,9 @@ To change this setting, <ph name="BEGIN_LINK">&lt;resetlink&gt;</ph>reset sync<p
<message name="IDS_READER_MODE_MESSAGE_BUTTON" desc="The label for the button to open the current page in reader mode.">
View
</message>
<message name="IDS_READER_MODE_ACTION_CHIP_LABEL_SIMPLIFY_PAGE" desc="The label for the action chip shown on the toolbar to open the current page in reader mode. [CHAR_LIMIT=27]">
Simplify page
</message>
<message name="IDS_CONTENT_PROVIDER_SEARCH_DESCRIPTION" desc="Description for Chrome's entry in QSB's list of search suggestion providers [CHAR_LIMIT=32]">
Bookmarks and web history
</message>
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
cc906f2a37f0700e0fa5b7cfdc7c871f05a0a063

0 comments on commit c38a889

Please sign in to comment.