UNLOCK image if image is zoomedOut #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is for better performance
if the user scales the image bigger than its initialScale the scaleState will be 'zoomedIn' ... otherwise -> 'zoomedOut' currently the trigger point is the initialScale at this point additional customization of the trigger point will be EASY
|
Thanks for your contribution. I will look carefully into it. |
Carlit0
commented
Apr 16, 2019
|
|
CarSmallGuo
pushed a commit
to CarSmallGuo/photo_view
that referenced
this pull request
May 29, 2019
UNLOCK image if image is zoomedOut
CarSmallGuo
pushed a commit
to CarSmallGuo/photo_view
that referenced
this pull request
May 30, 2019
UNLOCK image if image is zoomedOut
CarSmallGuo
pushed a commit
to CarSmallGuo/photo_view
that referenced
this pull request
May 30, 2019
UNLOCK image if image is zoomedOut
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GREAT REPO! 👍
I have added two more scaleStates: 'zoomedIn' and 'zoomedOut'.
The trigger between those two states is currently the initialScale:
zoomedOut <= initialScale < zoomedIn
zoomedOut -> unlocks the image
zoomedIn -> locks the image
The (default)StateCycle stays the same.
However, the scaleState 'zooming' becomes unnecessary.
I've encountered some performance issues, so I've implemented a new stream that will fire ONLY if a scaleState change is detected.
At this point, the additional customization of the trigger point will be EASY :)
i guess this will fix #105
and is at least an approach for #41