Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(#212) GestureDetector winning arena #266

Merged
merged 1 commit into from
Mar 23, 2020
Merged

Conversation

renancaraujo
Copy link
Member

Straight up mark gesture as won when a gesture scope is detected, instead f calli9ng resolve, which interferes on ScaleGestureRecognizer's lifecycle.

Supposedly should fix #212 and correlates.

@renancaraujo renancaraujo force-pushed the fix-gallery-pagechange branch from aeac684 to a0023aa Compare March 14, 2020 18:31
@renancaraujo
Copy link
Member Author

@criswonder @hugocbpassos Since I'm not able to reproduce the bug properly, I will have to ask for you people to kindly reproduce it for me?

@ghost
Copy link

ghost commented Mar 14, 2020

Currently, I'm not able to reproduce it, but I'll do as soon as I can.

@renancaraujo renancaraujo merged commit 5cbd22f into master Mar 23, 2020
@renancaraujo renancaraujo deleted the fix-gallery-pagechange branch August 12, 2020 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]Gallery can't change page smoothly
1 participant