Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates GitHub Actions setup-python #184

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

amarvin
Copy link

@amarvin amarvin commented Mar 1, 2023

Proposed Changes

  • Updates setup-python action for CI/CD pipeline

@amarvin amarvin requested a review from bluemania as a code owner March 1, 2023 04:04
@amarvin
Copy link
Author

amarvin commented Mar 1, 2023

Awesome work on this repo! I thought it'd be cool to help try to get the CI/CD pipelines working again. The last failed one is too old to show the log anymore, so I opened this PR to get a new run of the CI/CD pipeline that then would show an error to further troubleshoot.

Copy link
Owner

@bluemania bluemania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@amarvin
Copy link
Author

amarvin commented Mar 2, 2023

LGTM thanks!

Cool! Looks like "this workflow requires approval from a maintainer" - can you kick off the CI/CD?

@amarvin
Copy link
Author

amarvin commented Mar 2, 2023

Hmm, I was expecting the test workflow to run. Maybe I can get it to run in PRs.

@amarvin
Copy link
Author

amarvin commented Mar 2, 2023

Thanks, that ran the test workflow and showed the syntax for updating pip needed a fix. Can you approve the workflow again?

@amarvin
Copy link
Author

amarvin commented Mar 2, 2023

The last workflow error is a known issue with old versions of poetry, and is resolved with: python-poetry/poetry#6300 (comment). Can you approve the workflow again?

@amarvin
Copy link
Author

amarvin commented Mar 3, 2023

We're still getting workflow errors, but at least a new error now. This one might get resolved by updating nox-poetry (python-poetry/poetry#3472 (comment)).

@amarvin
Copy link
Author

amarvin commented Mar 3, 2023

Wow, the tests ran!

@amarvin
Copy link
Author

amarvin commented Mar 3, 2023

Seems like there's an issue within numpy used by pandas during test_e2e, which can be resolved by updating numpy (https://stackoverflow.com/a/66138833/6068036).

@bluemania
Copy link
Owner

OK just send a message here if you want me to come back and approve/rerun.

It was a fun project while i was working on it and i'm happy that you have interest in it.

I think most of the coding work here was to develop the data infrastructure and WoW UI interfacing; but there's a lot of potential to plug in different policies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants