-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add camera configuration UI #2857
Add camera configuration UI #2857
Conversation
57afd0c
to
b951958
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ES-Alexander (Mr. Elioto), can you put some of you magic touch in this range image ?
b951958
to
c78224f
Compare
@patrickelectric these were my original design suggestions: I expect @Williangalvani is starting out with a simpler interface, although given this PR is still a draft it's quite possibly still a WIP. We did have some discussions about the diagram for this being much more dynamic than the others (e.g. adjusting the diagram based on the specified values as well as the autopilot telemetry for the current orientation and mount tilt angles), which does also make it trickier to have hand-drawn aspects for things like the arrows, if we want them to have variable lengths depending on the angles being covered... There was also some discussion around a 3D interface, especially if we want to visualise the field of view: |
@ES-Alexander that is correct. I decided to start smaller as this will cover 90% of what we need. Just to avoid sinking too much time into it. I also had misunderstood how some of those parameters work, which is why they are gone. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ping @Williangalvani |
I second that it would be useful to have a "center" or "home", it may not be the center of the two values. For example, you may want to have less range of motion up than down, but still center straight ahead. |
hmmm interesting. that would require a small change on ardusub, but I think it is worth it |
fc5b6c7
to
c41f6e8
Compare
c41f6e8
to
27b0cc1
Compare
No description provided.