auth: support cookies as another form of auth #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paigen11
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Context
Notehub is switching internally to use the Notehub JS SDK, but it needs the ability to pass auth credentials as cookies for API requests instead of having to explicitly set an API key to go with every call.
Modify the Notehub JS library so it will accept either cookies or API keys for auth.
Changes
Enable cookies in the Notehub JS library, and modify the defaultHeaders so they don't throw a warning message about
unsafe headerwhen the API is used client-side.Testing
Automated tests pass?