Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Open only action panel when subject is opened from workspace #199

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

foysalit
Copy link
Contributor

No description provided.

@arcalinea arcalinea temporarily deployed to fix-subject-overview-link-in-workspace - ozone-staging PR #199 September 25, 2024 16:52 — with Render Destroyed
@foysalit foysalit merged commit 7345eaf into main Sep 25, 2024
3 checks passed
Copy link
Contributor

@matthieusieben matthieusieben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good !

Comment on lines +52 to +54
if (omitQueryParams?.length) {
omitQueryParams.forEach((param) => newUrl.delete(param))
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: could make this slightly shorter

Suggested change
if (omitQueryParams?.length) {
omitQueryParams.forEach((param) => newUrl.delete(param))
}
omitQueryParams?.forEach((param) => newUrl.delete(param))

@matthieusieben matthieusieben deleted the fix-subject-overview-link-in-workspace branch September 27, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants