Allow shared parent mock to be passed to Device.connect #599
Conversation
|
Would have to call attach_mock after each child device is connected as that is when the signal backend gets set to MockSignalBackend and the _backend.put_mock can be accessed. Tom has said he may touch how that is handled soon so I will wait for that to be done first. |
|
#594 is sufficiently advanced that you can work on top of it to see if you can apply this on top of it |
|
I've rebased on top of #594, still a WIP but it appears to work with the existing tests. I will work on porting over the new tests I added in the force-pushed-over commits here |
jsouter
force-pushed
the
shared_mock
branch
3 times, most recently
from
2785615
to
204aab2
Compare
|
|
||
| from ._device import Device |
There was a problem hiding this comment.
I think this is mostly in a sensible state now, depending on if we're happy with get_mock in _mock_signal_utils accepting Device | Signal
|
Shall I merge? |
I'm happy with it unless @DominicOram has any more thoughts |
Addresses #336
Allows a Device to accept a unittest.Mock or a boolean.
If True passed, creates a new Mock()
if Mock() passed, finds any child mocks set with attach_mock if they exist, else passes down mock=True to children.
Will push some tests for this
edit: now realising that I misunderstood the requirements, will fix quickly!