Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#106 - Cypress tests in CI #118

Merged
merged 24 commits into from
Oct 19, 2021
Merged

Conversation

EwelinaSkrzypacz
Copy link
Member

@EwelinaSkrzypacz EwelinaSkrzypacz commented Oct 13, 2021

This should close #106.
What's more, each test name starts with a capital letter. I think it looks better now.

@EwelinaSkrzypacz EwelinaSkrzypacz marked this pull request as ready for review October 18, 2021 08:07
Copy link
Member

@krzysztofrewak krzysztofrewak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see in logs some wierd errors:

[449:1018/074444.886066:ERROR:bus.cc(392)] Failed to connect to the bus: Address does not contain a colon

Source: https://github.com/blumilksoftware/website/runs/3923736062?check_suite_focus=true
Can you check it?

@EwelinaSkrzypacz
Copy link
Member Author

I can see in logs some wierd errors:

[449:1018/074444.886066:ERROR:bus.cc(392)] Failed to connect to the bus: Address does not contain a colon

Source: https://github.com/blumilksoftware/website/runs/3923736062?check_suite_focus=true Can you check it?

I checked it and if tests passes, we don't have to worry about this error. I think it's problem not related with Cypress, but with Docker. cypress-io/cypress#4925 (comment)

@EwelinaSkrzypacz EwelinaSkrzypacz merged commit e812757 into master Oct 19, 2021
@EwelinaSkrzypacz EwelinaSkrzypacz deleted the #106-cypress-tests-in-CI branch October 19, 2021 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cypress tests in CI
3 participants