Celsius air conditioners will not set temperature

[amaisano]

frigidaire/frigidaire/__init__.py

Lines 211 to 214 in 3b8e354

	def set_temperature(cls, temperature: int) -> List[Component]:
	# This is a restriction set by Frigidaire
	if temperature < 60 or temperature > 90:
	raise FrigidaireException("Temperature must be between 60 and 90 degrees, inclusive")

Why is this hard coded to Fahrenheit? My AC units are all set (individual settings in the 2.0 app, and in the profile settings of the 3.0 2023 app) to show as Celsius.

(Yes, there are many people in the US that prefer Celsius, instead of Fahrenheit)

Home assistant is also set to Celsius.

When I try to request 24° C, I get this error:

Temperature must be between 60 and 90 degrees, inclusive

Which makes no sense. I think we need a check for units, but I'm having a hard time determining if we can get that info reliably from the API. If not, maybe a user variable setting?

[amaisano]

FYI here is the logic in the supplicant HA component, homebridge-frigidaire:

    @property
    def min_temp(self):
        """Return the minimum temperature."""
        if self.temperature_unit == TEMP_FAHRENHEIT:
            return 60

        return 16

    @property
    def max_temp(self):
        """Return the maximum temperature."""
        if self.temperature_unit == TEMP_FAHRENHEIT:
            return 90

        return 32

[amaisano]

In the meantime, I am currently hacking the homebridge-frigidaire component by adding this if statement to the set_temperature function in order to convert to F°:

        if self.temperature_unit == TEMP_CELSIUS:
          temperature = int(math.floor((temperature*9/5)+32))

[amaisano]

Bump

[rothn]

#22 would make this possible to specify manually as a user:

fr_api.execute_action(my_appliance, [
        frigidaire.Component(Setting.TARGET_TEMPERATURE_C, temperature)
])

A cleaner way to address this upstream might be to make set_temperature() take an Optional[Unit] that defaults to fahrenheit (to preserve backward compatibility, e.g. for the homeassistant integration).

[amaisano]

bump

[amaisano]

why is everything hardcoded in F ???

[rothn]

The maintainers are most likely from North America-- I know I am-- and too busy with other things in our personal lives to add functionality that doesn't benefit us (again, I know I am). It should be a relatively simple change, as detailed by my comments above.

[bm1549]

Closed via #34