Allow setting of temperature unit (F or C) when setting temperature #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expose set_temperature_{f,c} functions wrapping the underlinging
Frigidaire actions Setting.TARGET_TEMPERATURE_{F,C}. This allows users
of this client (e.g. the Home Assistant component) to set a target
temperature in either F or C without performing temperature conversion;
callers that natively use F will set the TARGET_TEMPERATURE_F, while
callers that store C will set the TARGET_TEMPERATURE_C.
These two functions replace the previous `set_temperature()` function
(which implicitly required callers to convert target temperatures to
degrees Fahrenheit), and so constitute a breaking API change.
Supports fixing bm1549/home-assistant-frigidaire#56
This was referenced Sep 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built on top of #37 (thank you @casebeer !)
Allows for the setting of temperature Unit (either
Unit.FAHRENHEITorUnit.CELSIUS) when usingset_temperatureSupports fixing bm1549/home-assistant-frigidaire#56
Should also address remaining issues with #19 (as noted in #34 (comment))