Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PiP broken #130

Closed
Schoggiweggli opened this issue Jan 29, 2024 · 2 comments
Closed

PiP broken #130

Schoggiweggli opened this issue Jan 29, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@Schoggiweggli
Copy link

Schoggiweggli commented Jan 29, 2024 •
edited
Loading

The media controls are missing from the PiP window when Edge-Frfox is installed.
Doubleclick to go full screen from the PiP window doesn't work either, nothing happens.

Configuration

  • Firefox Version: 122.0
  • OS: Windows 10 x64
  • Tweaks enabled: uc.tweak.rounded-corners
@Schoggiweggli Schoggiweggli added the bug Something isn't working label Jan 29, 2024
@KiKaraage
Copy link

Experienced similar thing. In my case, media controls still exist for videos, but there's no progress bar at all. Music PiP just showed the close and enlarge button

bmFtZQ added a commit that referenced this issue Jan 30, 2024
@bmFtZQ
Fix PIP controls not showing #130
d5f24b5 
Fix picture-in-picture controls not showing on hover when the rounded
corners tweak is enabled.

Also disables rounded corners on pop-up windows (such as extension pop
-ups).
@bmFtZQ
Copy link
Owner

bmFtZQ commented Jan 30, 2024 •
edited
Loading

This was caused by the video element and the browser element in the main window sharing the same ID. A rule that changes the z-index of the browser was used to prevent overlapping toolbars when the rounded corners tweak was enabled.

The controls were still being displayed, but they were behind the video player. This should be fixed in the newest commit of the theme.

@bmFtZQ bmFtZQ closed this as completed Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@KiKaraage @Schoggiweggli @bmFtZQ