Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 1.6.0 #64

Closed
bmatsuo opened this issue Mar 31, 2016 · 2 comments
Closed

Release 1.6.0 #64

bmatsuo opened this issue Mar 31, 2016 · 2 comments
Milestone
v1.6.0

Comments

@bmatsuo
Copy link
Owner

bmatsuo commented Mar 31, 2016

There is a sizable chunk of CHANGES not tagged in a release. I think after the bug fix #57, which caused a performance degration, and the optimization #62 I think things are in a decent spot for a new tag to be created.

The tag will probably be made in the next couple days. After the freshest commits have cured for a short time.
@bmatsuo bmatsuo added this to the v1.6.0 milestone Mar 31, 2016
bmatsuo added a commit that referenced this issue Mar 31, 2016
@bmatsuo
as an experiment, switch void* cgo arguments with char*
7d11641 
It was discovered in #64 that void* arguments cause allocations in cgo
and extra time checking arguments as opposed to char* arguments.

The issue golang/go#14387 claims that it will fix this problem but I am
going to keep this patch around for testing against tip and later
merging if necessary.
@bmatsuo
Copy link
Owner Author

bmatsuo commented Apr 2, 2016

Postponing this to include the optimization discussed in #63.

The release will not include #65 so there are no compatibility concerns.

@bmatsuo
Copy link
Owner Author

bmatsuo commented Apr 6, 2016

Also added #67 because it's technically a defect, though it has been around for a while.

@bmatsuo bmatsuo mentioned this issue Apr 7, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.6.0
Development

No branches or pull requests
1 participant
@bmatsuo