Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to React 17 #23

Closed
bmaupin opened this issue Oct 22, 2021 · 1 comment
Closed

Upgrade to React 17 #23

bmaupin opened this issue Oct 22, 2021 · 1 comment
Labels
dependencies Pull requests that update a dependency file

Comments

@bmaupin
Copy link
Owner

bmaupin commented Oct 22, 2021

Right now we can't upgrade to React 17 because of react-vis, which only has React 16 as a dependency in its package.json (uber/react-vis#1356)

However, once NPM adds support for dependency overrides we may be able to override this (npm/rfcs#129)

@bmaupin bmaupin added the dependencies Pull requests that update a dependency file label Oct 25, 2021
@bmaupin bmaupin mentioned this issue Dec 3, 2021
18 tasks
@bmaupin
Copy link
Owner Author

bmaupin commented Jan 5, 2022

NPM overrides have been added in v8.3.0

https://docs.npmjs.com/cli/v8/configuring-npm/package-json#overrides

So something like this might work:

  "overrides": {
    "react": "^17.0.0"

However, since react-vis is unmaintained this is ultimately just kicking the can down the road and a replacement should probably be found, e.g. #26

bmaupin added a commit that referenced this issue Mar 15, 2023
... also upgrade react-scripts to latest version

Closes #23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

No branches or pull requests

1 participant