Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add a guard against maliciously-sized cookies #39

Merged
merged 2 commits into from
Dec 13, 2022

Conversation

andyburke
Copy link
Collaborator

@andyburke andyburke commented Dec 9, 2022

This adds a guard to limit cookie strings we will attempt to parse to 32768 characters. I believe this is in compliance with the RFC:

Limits

Practical user agent implementations have limits on the number and size of cookies that they can store. General-use user agents SHOULD provide each of the following minimum capabilities:

o At least 4096 bytes per cookie (as measured by the sum of the length of the cookie's name, value, and attributes).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant