removing file_get_contents() usages (#992)

* removing file_get_contents() usages

* allowing build.txt to be include in the storage path

.github/workflows/release.yml

@@ -136,7 +136,7 @@ jobs:
           DISABLE_NOTIFIER=true make deploy
           unzip ${ARTIFACT_FILENAME}
           rm ${ARTIFACT_FILENAME}
-          echo ${GITHUB_SHA} > ${ARTIFACT_FILE}/build.txt
+          echo ${GITHUB_SHA} > ${ARTIFACT_FILE}/storage/app/build.txt
           cp -R vendor ${ARTIFACT_FILE}/
           mkdir -p ${ARTIFACT_FILE}/public/dist && cp -R public/dist/. ${ARTIFACT_FILE}/public/dist
           find ./${ARTIFACT_FILE} -type d | xargs chmod 755

.github/workflows/unstable.yml

@@ -124,7 +124,7 @@ jobs:
           DISABLE_NOTIFIER=true make deploy
           unzip ${ARTIFACT_FILENAME}
           rm ${ARTIFACT_FILENAME}
-          echo ${GITHUB_SHA} > ${ARTIFACT_FILE}/build.txt
+          echo ${GITHUB_SHA} > ${ARTIFACT_FILE}/storage/app/build.txt
           cp -R vendor ${ARTIFACT_FILE}/
           mkdir -p ${ARTIFACT_FILE}/public/dist && cp -R public/dist/. ${ARTIFACT_FILE}/public/dist
           find ./${ARTIFACT_FILE} -type d | xargs chmod 755

README.md

@@ -28,9 +28,7 @@ For setup instructions and general documentation please visit [https://yap.bmlt.
 
 # ⚠️ Major Refactor
 
-Currently we are in the process of doing a major overhaul of the codebase, by migrating all the legacy PHP to a more Laravel-like structure.  This will improve the stability and maintainability.  Also, as part of this change, we are making the code more testable which will help us track code paths more effectively.  We also plan to redo the frontend part of it migrating from a Bootstrap/Jquery structure to React.
-
-All the legacy components has been migrated.  We are doing some final testing now.
+Currently we are in the process of doing a major overhaul of the codebase.  This will improve the stability and maintainability.  Also, as part of this change, we are making the code more testable which will help us track code paths more effectively.  All the PHP code has been migrated, however there are some remaining database components that are not in a Laravel-like structure.
 
 In a future release we will refactor the frontend by building a new React application to consume the rebuilt APIs, that work has partially started but has been put on pause.
 

RELEASENOTES.md

@@ -3,6 +3,7 @@
 ### 4.3.3 (UNRELEASED)
 * Fix for reports where they are always recursing service bodies regardless of the setting [#980]
 * Fix for metrics counts summaries.
+* Removing `file_get_contents()` usage to support some cases where servers may be misconfigured.
 * Using native Laravel database migrations.
 
 ### 4.3.2 (March 21, 2024)

app/Http/Controllers/VoicemailController.php

@@ -4,6 +4,7 @@
 
 use App\Constants\EventId;
 use App\Constants\VolunteerResponderOption;
+use App\Exceptions\NoVolunteersException;
 use App\Services\CallService;
 use App\Services\ConfigService;
 use App\Services\RootServerService;
@@ -12,6 +13,7 @@
 use App\Services\VoicemailService;
 use App\Services\VolunteerService;
 use Illuminate\Http\Request;
+use Illuminate\Support\Facades\Log;
 use Twilio\TwiML\VoiceResponse;
 
 class VoicemailController extends Controller
@@ -101,24 +103,28 @@ public function complete(Request $request)
             );
         }
 
-        if (isset($_SESSION["volunteer_routing_parameters"])) {
-            $volunteer_routing_options = $_SESSION["volunteer_routing_parameters"];
-            $volunteer_routing_options->volunteer_responder = VolunteerResponderOption::ENABLED;
-            $volunteers = $this->volunteers->getHelplineVolunteersActiveNow($volunteer_routing_options);
-            $recipients = [];
-            foreach ($volunteers as $volunteer) {
-                $recipients[] = $volunteer->contact;
-            }
-            if (count($volunteers) > 0) {
-                $this->voicemail->sendSmsForVoicemail(
-                    $callSid,
-                    $recordingUrl,
-                    $recipients,
-                    $serviceBodyCallHandling,
-                    $serviceBodyName,
-                    $callerNumber
-                );
+        try {
+            if (isset($_SESSION["volunteer_routing_parameters"])) {
+                $volunteer_routing_options = $_SESSION["volunteer_routing_parameters"];
+                $volunteer_routing_options->volunteer_responder = VolunteerResponderOption::ENABLED;
+                $volunteers = $this->volunteers->getHelplineVolunteersActiveNow($volunteer_routing_options);
+                $recipients = [];
+                foreach ($volunteers as $volunteer) {
+                    $recipients[] = $volunteer->contact;
+                }
+                if (count($volunteers) > 0) {
+                    $this->voicemail->sendSmsForVoicemail(
+                        $callSid,
+                        $recordingUrl,
+                        $recipients,
+                        $serviceBodyCallHandling,
+                        $serviceBodyName,
+                        $callerNumber
+                    );
+                }
             }
+        } catch (NoVolunteersException $nve) {
+            Log::debug("complete() :: " . $nve);
         }
 
         if ($serviceBodyCallHandling->primary_contact_email_enabled && $this->settings->has('smtp_host')) {

app/Services/UpgradeService.php

@@ -7,6 +7,7 @@
 use Exception;
 use Illuminate\Support\Facades\App;
 use Illuminate\Support\Facades\DB;
+use Illuminate\Support\Facades\Storage;
 
 class UpgradeService extends Service
 {
@@ -123,7 +124,7 @@ public function getStatus()
     private function getState($status = null, $message = null, $warnings = "")
     {
         try {
-            $build = file_get_contents("build.txt", false);
+            $build = Storage::get("build.txt");
         } catch (Exception $e) {
             $build = $e->getMessage();
         }

app/Services/VoicemailService.php

@@ -5,6 +5,7 @@
 use App\Constants\SmtpPorts;
 use Exception;
 use Illuminate\Support\Facades\App;
+use Illuminate\Support\Facades\Http;
 use Illuminate\Support\Facades\Log;
 use PHPMailer\PHPMailer\PHPMailer;
 use App\Constants\SmsDialbackOptions;
@@ -65,12 +66,14 @@ public function sendEmailForVoicemail($recordingUrl, $recipients, $serviceBodyNa
             foreach ($recipients as $recipient) {
                 $this->mailer->addAddress($recipient);
             }
-            $this->mailer->addStringAttachment(file_get_contents($recordingUrl . ".mp3"), $recordingUrl . ".mp3");
+            $recordingUrlWithExtension = sprintf("%s.mp3", $recordingUrl);
+            $recordingDataString = Http::get($recordingUrlWithExtension);
+            $this->mailer->addStringAttachment($recordingDataString, $recordingUrlWithExtension);
             $this->mailer->Body = "You have a message from the " . $serviceBodyName . " helpline from caller " . $callerNumber . ", " . $recordingUrl. ".mp3";
             $this->mailer->Subject = 'Helpline Voicemail from ' . $serviceBodyName;
             $this->mailer->send();
         } catch (Exception $e) {
-            Log::critical('Message could not be sent. Mailer Error: ' . $this->mailer->ErrorInfo);
+            Log::critical('Message could not be sent. Mailer Error: ' . $e);
         }
     }
 }

storage/app/.gitignore

@@ -1,3 +1,4 @@
 *
 !public/
 !.gitignore
+!build.txt

tests/Feature/VoicemailCompleteTest.php

@@ -32,7 +32,7 @@
     $this->utility = setupTwilioService();
     $this->callSid = "abc123";
     $this->callerNumber = "+17325551212";
-    $this->recordingUrl = "file:///".getcwd()."/tests/fake";
+    $this->recordingUrl = "https://example.org/tests/fake";
     $expectedPin = 4182804;
 
     $reportsRepository = mock(ReportsRepository::class)->makePartial();
@@ -184,10 +184,10 @@
     $callContextMock->shouldReceive('update')
         ->with(Mockery::on(function ($data) {
             return $data['status'] == TwilioCallStatus::COMPLETED;
-        }));
+        }))->once();
     $this->utility->client->shouldReceive('calls')
         ->with($this->callSid)
-        ->andReturn($callContextMock);
+        ->andReturn($callContextMock)->once();
 
     $repository = Mockery::mock(ConfigRepository::class);
     $repository->shouldReceive("getDbData")->with(