Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't print environment #20

Merged
merged 1 commit into from
Feb 17, 2021
Merged

Don't print environment #20

merged 1 commit into from
Feb 17, 2021

Conversation

britter
Copy link
Contributor

@britter britter commented Feb 16, 2021

Fixes #19

@britter
Copy link
Contributor Author

britter commented Feb 16, 2021

I did not change the way envp is created because I realized that the environment will be inherited anyway when the new process is spawned. That's probably the reason why null is passed if the user supplied environment variables are empty.

@bmuschko bmuschko added this to the v3.0.0 milestone Feb 17, 2021
@bmuschko bmuschko added the bug label Feb 17, 2021
@bmuschko bmuschko self-assigned this Feb 17, 2021
@bmuschko bmuschko added enhancement and removed bug labels Feb 17, 2021
@bmuschko bmuschko merged commit d14d2bb into bmuschko:master Feb 17, 2021
@JLLeitschuh
Copy link

This has been assigned CVE-2021-21361
GHSA-jpcm-4485-69p7

@britter britter deleted the issues/19/envp-logging branch March 9, 2021 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bmuschko bmuschko

Labels
enhancement
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.

Potential credentials leak when setting environmentVariables
3 participants
@britter @JLLeitschuh @bmuschko