Installation retry #240
Open
Installation retry #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
almusil
force-pushed
the
install_retry
branch
2 times, most recently
from
b9c6192
to
bfac27f
Compare
bn222
reviewed
Sep 2, 2024
bn222
reviewed
Sep 2, 2024
bn222
reviewed
Sep 2, 2024
bn222
force-pushed
the
main
branch
3 times, most recently
from
3a06bf8
to
ad13ce1
Compare
almusil
force-pushed
the
install_retry
branch
from
bfac27f
to
f7c9cc3
Compare
|
@bn222 It is updated as we have agreed on, please take a look when you have some time |
almusil
force-pushed
the
install_retry
branch
from
f7c9cc3
to
560ce0a
Compare
almusil
force-pushed
the
install_retry
branch
2 times, most recently
from
5b4e167
to
e7f2cc6
Compare
bn222
reviewed
Sep 18, 2024
| @@ -99,7 +99,7 @@ def download_iso_with_retry(self, infra_env: str, path: str = os.getcwd()) -> No | |||
| except Exception: | |||
| time.sleep(timeout) | |||
| else: | |||
| logger.error(f"Failed to download the ISO after {retries} attempts") | |||
| logger.error_and_exit(f"Failed to download the ISO after {retries} attempts") | |||
almusil
force-pushed
the
install_retry
branch
from
e7f2cc6
to
1e374cd
Compare
almusil
force-pushed
the
install_retry
branch
7 times, most recently
from
d0cde18
to
a2b59fe
Compare
|
@almusil thanks for the rebase. We are waiting for a green CI run due to other changes. We will merge this as soon as we know it doesn't break the rest. |
|
@bn222 Sounds good, thanks! |
almusil
force-pushed
the
install_retry
branch
2 times, most recently
from
2ca8c81
to
906d423
Compare
Slightly simplify the deployment process by moving/creating some additional helper functions. Signed-off-by: Ales Musil <amusil@redhat.com>
Instead of waiting for installation steps in bulk wait for every step in series per node. To achieve that make the installation process more serial, in other words, instead of waiting for all nodes to do something, do the in sequence and parallelize the sequence. This also serves as preparation for installation retry. Signed-off-by: Ales Musil <amusil@redhat.com>
If the worker installation ends up with error retry the installation until it suceeds, this should help mainly with VM workers that are deployed in larger batches. Signed-off-by: Ales Musil <amusil@redhat.com>
When the ISO doesn't come up in time fail the whole deployment, otherwise it might happen that the old ISO is used and the deployment gets stuck waiting for known status. The nodes will never register with old iso becuase the infraenv id doesn't match. Signed-off-by: Ales Musil <amusil@redhat.com>
almusil
force-pushed
the
install_retry
branch
from
906d423
to
1814db5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes the installation fails for various reasons in AI, most common was that the registry is not accessible and the agent won't be able to download it. Add retry mechanism to the installation of workers which greatly helps with that. This code has been running in our lab for more than a week without any issue.