[R4R]support blockhash context #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
abelliumnt
approved these changes
Sep 20, 2019
|
Why directly to master branch? |
rickyyangz
reviewed
Oct 23, 2019
baseapp/baseapp.go
Outdated
| } else { | ||
| // In the first block, app.DeliverState.Ctx will already be initialized | ||
| // by InitChain. Context is now updated with Header information. | ||
| app.DeliverState.Ctx = app.DeliverState.Ctx.WithBlockHeader(req.Header).WithBlockHeight(req.Header.Height) | ||
| app.DeliverState.Ctx = app.DeliverState.Ctx.WithBlockHeader(req.Header).WithBlockHeight(req.Header.Height).WithBlockHash(req.Hash) |
There was a problem hiding this comment.
put it before BlockHeader as BlockerHeader and BlockHeight are queried much more frequent
rickyyangz
approved these changes
Oct 23, 2019
yutianwu
approved these changes
Oct 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve bnb-chain/node#668
Just add blockHash to deliever context
docs/)PENDING.mdwith issue #Files changedin the github PR explorerFor Admin Use: