Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4R: Fix failack payload #247

Merged
merged 2 commits into from
Jan 4, 2021
Merged

R4R: Fix failack payload #247

merged 2 commits into from
Jan 4, 2021

Conversation

abelliumnt
Copy link
Contributor

According to our cross chain protocol, once there are panic in handling syn package in oracle app, an fail ack package will be generated. In the fail ack package, the syn payload will be write back to BSC. But the syn payload doesn't include package header. In currently implementation, the syn package header is also written back to BSC which result in BSC decoding issue. This PR will remove the syn package header before generating fail ack package.

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added entries in PENDING.md with issue #

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@abelliumnt abelliumnt changed the title WIP: Fix failack payload R4R: Fix failack payload Dec 25, 2020
@unclezoro unclezoro merged commit 32ba1b5 into develop Jan 4, 2021
@forcodedancing forcodedancing deleted the fix-failack-payload branch May 18, 2022 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants