address comments

bnb-chain · Jul 22, 2021 · 8975587 · 8975587
1 parent 94e1505
commit 8975587
Show file tree

Hide file tree

Showing 4 changed files with 48 additions and 45 deletions.
diff --git a/core/blockchain.go b/core/blockchain.go
@@ -23,7 +23,6 @@ import (
 	"io"
 	"math/big"
 	mrand "math/rand"
-	"runtime"
 	"sort"
 	"sync"
 	"sync/atomic"
@@ -88,7 +87,6 @@ const (
 	maxFutureBlocks     = 256
 	maxTimeFutureBlocks = 30
 	badBlockLimit       = 10
-	preLoadLimit        = 64
 	maxBeyondBlocks     = 2048
 
 	// BlockChainVersion ensures that an incompatible database forces a resync from scratch.
@@ -1883,44 +1881,7 @@ func (bc *BlockChain) insertChain(chain types.Blocks, verifySeals bool) (int, er
 		// Enable prefetching to pull in trie node paths while processing transactions
 		statedb.StartPrefetcher("chain")
 		activeState = statedb
-
-		accounts := make(map[common.Address]bool, block.Transactions().Len())
-		accountsSlice := make([]common.Address, 0, block.Transactions().Len())
-		for _, tx := range block.Transactions() {
-			from, err := types.Sender(signer, tx)
-			if err != nil {
-				break
-			}
-			accounts[from] = true
-			if tx.To() != nil {
-				accounts[*tx.To()] = true
-			}
-		}
-		for account, _ := range accounts {
-			accountsSlice = append(accountsSlice, account)
-		}
-		if len(accountsSlice) >= preLoadLimit {
-			objsChan := make(chan []*state.StateObject, runtime.NumCPU())
-			for i := 0; i < runtime.NumCPU(); i++ {
-				start := i * len(accountsSlice) / runtime.NumCPU()
-				end := (i + 1) * len(accountsSlice) / runtime.NumCPU()
-				if i+1 == runtime.NumCPU() {
-					end = len(accountsSlice)
-				}
-				go func(start, end int) {
-					objs := statedb.PreloadStateObject(accountsSlice[start:end])
-					objsChan <- objs
-				}(start, end)
-			}
-			for i := 0; i < runtime.NumCPU(); i++ {
-				objs := <-objsChan
-				if objs != nil {
-					for _, obj := range objs {
-						statedb.SetStateObject(obj)
-					}
-				}
-			}
-		}
+		statedb.TryPreload(block, signer)
 
 		//Process block using the parent state as reference point
 		substart := time.Now()

diff --git a/core/state/statedb.go b/core/state/statedb.go
@@ -38,7 +38,10 @@ import (
 	"github.com/ethereum/go-ethereum/trie"
 )
 
-const defaultNumOfSlots = 100
+const (
+	preLoadLimit      = 64
+	defaultNumOfSlots = 100
+)
 
 type revision struct {
 	id           int
@@ -516,7 +519,47 @@ func (s *StateDB) getStateObject(addr common.Address) *StateObject {
 	return nil
 }
 
-func (s *StateDB) PreloadStateObject(address []common.Address) []*StateObject {
+func (s *StateDB) TryPreload(block *types.Block, signer types.Signer) {
+	accounts := make(map[common.Address]bool, block.Transactions().Len())
+	accountsSlice := make([]common.Address, 0, block.Transactions().Len())
+	for _, tx := range block.Transactions() {
+		from, err := types.Sender(signer, tx)
+		if err != nil {
+			break
+		}
+		accounts[from] = true
+		if tx.To() != nil {
+			accounts[*tx.To()] = true
+		}
+	}
+	for account, _ := range accounts {
+		accountsSlice = append(accountsSlice, account)
+	}
+	if len(accountsSlice) >= preLoadLimit && len(accountsSlice) > runtime.NumCPU() {
+		objsChan := make(chan []*StateObject, runtime.NumCPU())
+		for i := 0; i < runtime.NumCPU(); i++ {
+			start := i * len(accountsSlice) / runtime.NumCPU()
+			end := (i + 1) * len(accountsSlice) / runtime.NumCPU()
+			if i+1 == runtime.NumCPU() {
+				end = len(accountsSlice)
+			}
+			go func(start, end int) {
+				objs := s.preloadStateObject(accountsSlice[start:end])
+				objsChan <- objs
+			}(start, end)
+		}
+		for i := 0; i < runtime.NumCPU(); i++ {
+			objs := <-objsChan
+			if objs != nil {
+				for _, obj := range objs {
+					s.SetStateObject(obj)
+				}
+			}
+		}
+	}
+}
+
+func (s *StateDB) preloadStateObject(address []common.Address) []*StateObject {
 	// Prefer live objects if any is available
 	if s.snap == nil {
 		return nil

diff --git a/eth/downloader/api.go b/eth/downloader/api.go
@@ -20,9 +20,8 @@ import (
 	"context"
 	"sync"
 
-	"github.com/ethereum/go-ethereum/common/gopool"
-
 	"github.com/ethereum/go-ethereum"
+	"github.com/ethereum/go-ethereum/common/gopool"
 	"github.com/ethereum/go-ethereum/event"
 	"github.com/ethereum/go-ethereum/rpc"
 )

diff --git a/p2p/rlpx/rlpx.go b/p2p/rlpx/rlpx.go
@@ -36,12 +36,12 @@ import (
 
 	"github.com/VictoriaMetrics/fastcache"
 	"github.com/golang/snappy"
+	"github.com/oxtoacart/bpool"
 	"golang.org/x/crypto/sha3"
 
 	"github.com/ethereum/go-ethereum/crypto"
 	"github.com/ethereum/go-ethereum/crypto/ecies"
 	"github.com/ethereum/go-ethereum/rlp"
-	"github.com/oxtoacart/bpool"
 )
 
 var snappyCache *fastcache.Cache