Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: fix potential goroutine leak #1079

Merged
merged 2 commits into from
Sep 19, 2022
Merged

core: fix potential goroutine leak #1079

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d7833ef
core: fix potential goroutine leak
qinglin89 Sep 5, 2022
f993fa6
core: fix 0 index, and add ut for routineleaking
qinglin89 Sep 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions core/state_prefetcher.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ func (p *statePrefetcher) Prefetch(block *types.Block, statedb *state.StateDB, c
)
transactions := block.Transactions()
txChan := make(chan int, prefetchThread)
defer close(txChan)
brilliant-lx marked this conversation as resolved.
Show resolved Hide resolved
// No need to execute the first batch, since the main processor will do it.
for i := 0; i < prefetchThread; i++ {
go func() {
Expand All @@ -63,6 +64,10 @@ func (p *statePrefetcher) Prefetch(block *types.Block, statedb *state.StateDB, c
gaspool := new(GasPool).AddGas(block.GasLimit())
blockContext := NewEVMBlockContext(header, p.bc, nil)
evm := vm.NewEVM(blockContext, vm.TxContext{}, statedb, p.config, *cfg)
defer func() {
for range txChan {
}
}()
// Iterate over and process the individual transactions
for {
select {
Expand Down