Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alls: sync with upstream #1181

Merged
merged 5 commits into from
Nov 15, 2022
Merged

Conversation

kyrie-yl
Copy link
Contributor

Description

Sync with go-ethereum 1.10.21, mainly include the some bugfix, code improvement and performance optimization.

Rationale

  1. resolve bugs: abigen failed if the abi file include keywords of golang; fix httpserver graceful shutdown timeout.
  2. pre-allocate to reduce the map resizing.
  3. improve code quality.

Example

None

Changes

Notable changes:

  • accounts/abi: substitude arg%d to the range keyword
  • Remove locking in (*BlockChain).ExportN
  • internal/ethapi: error if tx args includes chain id that doesn't match local
  • core, eth: pre-allocate in Copy()
  • rpc: add graceful shutdown timeout for HTTP server

henridf and others added 5 commits November 14, 2022 15:22
* Remove locking in (*BlockChain).ExportN

Since ExportN is read-only, it shouldn't need the lock. (?)

* Add hash check to detect reorgs during export.

* fix check order

* Update blockchain.go

* Update blockchain.go

Co-authored-by: rjl493456442 <garyrong0905@gmail.com>
…h local (#25157)

* internal/ethapi: error if tx args includes chain id that doesn't match local

* internal/ethapi: simplify code a bit

Co-authored-by: Péter Szilágyi <peterke@gmail.com>
This change ensures the HTTP server will always terminate within
at most 5s, even when all connections are busy and do not become
idle.

Co-authored-by: Felix Lange <fjl@twurst.com>
* accounts/abi: substitude arg%d to the range keyword

* support more keywords

* review feedback
@brilliant-lx brilliant-lx merged commit bf1dbd9 into bnb-chain:develop Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants