Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove naturally finality #1651

Merged
merged 1 commit into from
May 30, 2023

Conversation

NathanBSC
Copy link
Contributor

@NathanBSC NathanBSC commented May 25, 2023

Description

remove naturally finality

Rationale

naturally finality is alias of probabilistic finality in the code.

  1. The probabilistic finality is only probabilistic. In extreme cases, it may be reverted without penalty, so it is not suitable to acknowledge it through the interface
  2. Different application scenarios of probabilistic finality may choose different numbers of blocks. For example, 15 is recommended, while the main station uses 21 for deposits and withdrawals. but only a fixed number can be specified in the code
  3. The Ethereum client will also degenerate to a probabilistic finality when the vote fails, but the number of blocks is not specified in the code; Bitcoin has probabilistic finality, and the number of blocks is not specified in the code

Example

add an example CLI or API response...

Changes

Notable changes:

  • add each change in a bullet point here
  • ...

@emailtovamos
Copy link
Contributor

What exactly is the reason for removal of NaturallyFinalizedDist ? I didn't quite understand the rationale given.

@NathanBSC
Copy link
Contributor Author

What exactly is the reason for removal of NaturallyFinalizedDist ? I didn't quite understand the rationale given.

reason updated

@NathanBSC NathanBSC requested a review from unclezoro May 26, 2023 01:19
@NathanBSC NathanBSC merged commit 3d8753c into bnb-chain:develop May 30, 2023
@NathanBSC NathanBSC deleted the remove_naturally_finality branch May 30, 2023 01:56
setunapo added a commit to setunapo/bsc-erigon that referenced this pull request May 31, 2023
setunapo added a commit to node-real/bsc-erigon that referenced this pull request May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants