cmd/geth: fix error when writing state history after covert from hbss to pbss #1906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fynnss
force-pushed
the
fix_state_history_write_error
branch
from
341cbcc
to
e02ad5c
Compare
fynnss
changed the title
fynnss
force-pushed
the
fix_state_history_write_error
branch
from
e02ad5c
to
4259f4c
Compare
joeylichang
reviewed
Oct 7, 2023
| op.AppendRaw(stateHistoryAccountData, id-1, accounts) | ||
| op.AppendRaw(stateHistoryStorageData, id-1, storages) | ||
| err := op.AppendRaw(stateHistoryMeta, id-1, meta) | ||
| if err != nil { |
There was a problem hiding this comment.
Why did the community ignore this error?
Why can't we ignore it?
There was a problem hiding this comment.
It's possible that this issue hasn't come up for them before.
And we also ignore it. Take a look at the code in db.ModifyAncients and WriteStateHistory. In these sections, we intentionally disregard this error and don't propagate it further.
joeylichang
approved these changes
Oct 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When trieNode is converted from hbss to pbss format, the historical state data also needs to be modified accordingly, otherwise the following error will occur:
Rationale
This PR modifies the meta of the freezer table to avoid the above error, and enables continued writing of historical state after block chasing.
Example
Changes
Notable changes: