Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

code: remove accountTrieCache and storageTrieCache #1949

Merged
merged 2 commits into from
Oct 30, 2023
Merged

code: remove accountTrieCache and storageTrieCache #1949

merged 2 commits into from
Oct 30, 2023

Commits on Oct 27, 2023

  1. code: remove accountTrieCache and storageTrieCache 

    accountTrieCache and storageTrieCache were introduced in this PR:
bnb-chain#257, which is to improve performance.
Actually the performance gain is quite limitted, as there is already dirty
and clean cache for trie node.
And after big merge, these 2 cache can not be used when PBSS is enabled.
So remove these code to simplify the logic.
    @brilliant-lx
    brilliant-lx committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    0b0c964 View commit details
    Browse the repository at this point in the history

  2. code: minor code update

    @brilliant-lx
    brilliant-lx committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    6234884 View commit details
    Browse the repository at this point in the history