feat: support MEV #2214
Closed
feat: support MEV #2214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* core/types: define Bid and related error message * internal/eth_api: add MevAPI to receive bids from builder * eth/api_admin: add API to support start and stop mev dynamically * miner: add bidSimulator to maintain bid simulation and fetch best bid from * consensus: add func to query the next inturn validator
unclezoro
reviewed
Feb 19, 2024
|
|
||
| // BidArgs represents the arguments to submit a bid. | ||
| type BidArgs struct { | ||
| // bid |
There was a problem hiding this comment.
// bid seems not a good comment.
unclezoro
reviewed
Feb 19, 2024
| return hash.(common.Hash) | ||
| } | ||
|
|
||
| h := rlpHash(b) |
There was a problem hiding this comment.
Please update the code to latest version.
unclezoro
reviewed
Feb 19, 2024
| // TODO put validator and builder here or parsing by header? | ||
| Validator common.Address | ||
| Builder common.Address | ||
| BlockNumber uint64 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rationale
bnb-chain/BEPs#322 (comment)
Example
add an example CLI or API response...
Changes
Notable changes: