freezer: Opt freezer env checking #2580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buddh0
previously approved these changes
Jul 15, 2024
zzzckck
reviewed
Jul 15, 2024
zzzckck
reviewed
Jul 15, 2024
zzzckck
reviewed
Jul 15, 2024
buddh0
previously approved these changes
Jul 16, 2024
zzzckck
previously approved these changes
Jul 16, 2024
zzzckck
approved these changes
Jul 16, 2024
buddh0
approved these changes
Jul 16, 2024
This was referenced Jul 17, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a silent logic. For scenarios that require Freezer Env,
SetupFreezerEnvshould be called to initialize. For other scenarios, Freezer will silently wait 3 times and return, and will no longer execute freeze.Using silent logic effectively avoids large-scale API modifications and unnecessary DB initialization operations.
It fixed this issue, #2570
Changes
Notable changes: