Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core/state/snapshot: fix BAD BLOCK error when snapshot is generating … #485

Merged
merged 1 commit into from
Nov 1, 2021

Conversation

Mercybudda
Copy link
Contributor

@Mercybudda Mercybudda commented Oct 27, 2021

…(#23635)

  • core/state/snapshot: fix BAD BLOCK error when snapshot is generating

  • core/state/snapshot: alternative fix for the snapshot generator

  • add comments and minor update

Co-authored-by: Martin Holst Swende martin@swende.se

Description

fix BAD BLOCK error when snapshot is generating, cherry-picked the commit of go-ethereum: ethereum/go-ethereum@312e02b

Preflight checks

  • build passed (make build)
  • tests passed (make test)
  • manual transaction test passed

Related issues

ethereum/go-ethereum#23635

@unclezoro unclezoro changed the base branch from master to develop November 1, 2021 06:56
@unclezoro
Copy link
Collaborator

Can you change the code base to develop branch?

…(#23635)

* core/state/snapshot: fix BAD BLOCK error when snapshot is generating

* core/state/snapshot: alternative fix for the snapshot generator

* add comments and minor update

Co-authored-by: Martin Holst Swende <martin@swende.se>

* core/state/snapshot: fix BAD BLOCK error when snapshot is generating

* core/state/snapshot: alternative fix for the snapshot generator

* add comments and minor update

Co-authored-by: Martin Holst Swende <martin@swende.se>
@unclezoro unclezoro merged commit 354d0a4 into develop Nov 1, 2021
@Mercybudda Mercybudda deleted the fix_bad_block_cherry_pick branch November 2, 2021 08:38
@rothn
Copy link

rothn commented Apr 25, 2022

Looks like this fix got reverted for some reason by @greatestvillain. Does anyone know why? I'm having this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants