Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R4R]Feature/backport geth native trace #581

Merged
merged 24 commits into from
Dec 27, 2021
Merged

[R4R]Feature/backport geth native trace #581

merged 24 commits into from
Dec 27, 2021
+4,123 −1,341

Commits on Dec 10, 2021

  1. eth/tracers: implement debug.intermediateRoots (#23594) 

    This PR implements a new debug method, which I've talked briefly about to some other client developers. It allows the caller to obtain the intermediate state roots for a block (which might be either a canon block or a 'bad' block).
Signed-off-by: wenbiao <delweng@gmail.com>
    @holiman @rigsec
    holiman authored and rigsec committed Dec 10, 2021
    Configuration menu
    Copy the full SHA
    ddefb3a View commit details
    Browse the repository at this point in the history

  2. core, rpc: disable memory output by default in traces (#23558) 

    * core: cmd: invert disableMemory

* core: fix missed inversion

* cmd/evm: preserve Flags but change default value

* Apply suggestions from code review

Co-authored-by: Martin Holst Swende <martin@swende.se>

Co-authored-by: Martin Holst Swende <martin@swende.se>
Signed-off-by: wenbiao <delweng@gmail.com>
    @MariusVanDerWijden @holiman @rigsec
    2 people authored and rigsec committed Dec 10, 2021
    Configuration menu
    Copy the full SHA
    443d423 View commit details
    Browse the repository at this point in the history

  3. eth/tracers: abort evm execution when trace is aborted (#23580) 

    Signed-off-by: wenbiao <delweng@gmail.com>
    @holiman @rigsec
    holiman authored and rigsec committed Dec 10, 2021
    Configuration menu
    Copy the full SHA
    629c867 View commit details
    Browse the repository at this point in the history

  4. eth/tracers: avoid unsyncronized mutations on trie database (#23632) 

    This PR fixes an issue in traceChain, where the statedb Commit operation was performed asynchronously with dereference-operations agains the underlying trie.Database instance. Due to how the reference counting works within the trie database (where parent count is recursively updated when new parents are added), doing dereferencing in the middle of Commit can cause the refcount to become wrong, leading to an inconsistent state. 

This was fixed by doing Commit/Deref from the same routine.  
Signed-off-by: wenbiao <delweng@gmail.com>
    @holiman @rigsec
    holiman authored and rigsec committed Dec 10, 2021
    Configuration menu
    Copy the full SHA
    cd18225 View commit details
    Browse the repository at this point in the history

  5. core,eth: call frame tracing (#23087) 

    This change introduces 2 new optional methods; `enter()` and `exit()` for js tracers, and makes `step()` optiona. The two new methods are invoked when entering and exiting a call frame (but not invoked for the outermost scope, which has it's own methods). Currently these are the data fields passed to each of them:

    enter: type (opcode), from, to, input, gas, value
    exit: output, gasUsed, error

The PR also comes with a re-write of the callTracer. As a backup we keep the previous tracing script under the name `callTracerLegacy`. Behaviour of both tracers are equivalent for the most part, although there are some small differences (improvements), where the new tracer is more correct / has more information.

Signed-off-by: wenbiao <delweng@gmail.com>
    @s1na @rigsec
    s1na authored and rigsec committed Dec 10, 2021
    Configuration menu
    Copy the full SHA
    6e0eb98 View commit details
    Browse the repository at this point in the history

  6. eth/tracers: re-write of 4byte tracer using enter/exit (#23622) 

    * eth/tracers: add re-write of 4byte tracer using enter/exit

* eth/tracers: fix 4byte indent
Signed-off-by: wenbiao <delweng@gmail.com>
    @s1na @rigsec
    s1na authored and rigsec committed Dec 10, 2021
    Configuration menu
    Copy the full SHA
    651eba7 View commit details
    Browse the repository at this point in the history

  7. eth/tracers: tx.BaseFee not implemented 

    Signed-off-by: wenbiao <delweng@gmail.com>
    @jsvisa @rigsec
    jsvisa authored and rigsec committed Dec 10, 2021
    Configuration menu
    Copy the full SHA
    dbc6f1b View commit details
    Browse the repository at this point in the history

  8. eth/tracers: do the JSON serialization via .js to capture C faults 

    Signed-off-by: wenbiao <delweng@gmail.com>
    @karalabe @rigsec
    karalabe authored and rigsec committed Dec 10, 2021
    Configuration menu
    Copy the full SHA
    b9c725f View commit details
    Browse the repository at this point in the history

  9. eth/tracers: fix callTracer fault handling (#23667) 

    * eth/tracers: fix calltracer fault handling

* eth/tracers: fix calltracer indentation
Signed-off-by: wenbiao <delweng@gmail.com>
    @s1na @rigsec
    s1na authored and rigsec committed Dec 10, 2021
    Configuration menu
    Copy the full SHA
    21f9a48 View commit details
    Browse the repository at this point in the history

  10. eth/tracers: invoke enter/exit on 0-value calls to inex accounts (#23… 

    …828)

Signed-off-by: wenbiao <delweng@gmail.com>
    @holiman @rigsec
    holiman authored and rigsec committed Dec 10, 2021
    Configuration menu
    Copy the full SHA
    3a5dc8e View commit details
    Browse the repository at this point in the history

  11. eth: make traceChain avoid OOM on long-running tracing (#23736) 

    This PR changes long-running chain tracing, so that it at some points releases the memory trie db, and switch over to a fresh disk-backed trie.
Signed-off-by: wenbiao <delweng@gmail.com>
    @holiman @rigsec
    holiman authored and rigsec committed Dec 10, 2021
    Configuration menu
    Copy the full SHA
    d198711 View commit details
    Browse the repository at this point in the history

  12. eth/tracers: expose contextual infos (block hash, tx hash, tx index) 

    Signed-off-by: wenbiao <wenbiao.zheng@ambergroup.io>
    @karalabe @rigsec
    karalabe authored and rigsec committed Dec 10, 2021
    Configuration menu
    Copy the full SHA
    54d7be2 View commit details
    Browse the repository at this point in the history

  13. eth/tracers: redefine Context 

    Signed-off-by: wenbiao <wenbiao.zheng@ambergroup.io>
    @rigsec
    rigsec committed Dec 10, 2021
    Configuration menu
    Copy the full SHA
    0ee0722 View commit details
    Browse the repository at this point in the history

  14. eth/tracers: support for golang tracers + add golang callTracer (#23708) 

    * eth/tracers: add basic native loader

* eth/tracers: add GetResult to tracer interface

* eth/tracers: add native call tracer

* eth/tracers: fix call tracer json result

* eth/tracers: minor fix

* eth/tracers: fix

* eth/tracers: fix benchTracer

* eth/tracers: test native call tracer

* eth/tracers: fix

* eth/tracers: rm extra make

Co-authored-by: Martin Holst Swende <martin@swende.se>

* eth/tracers: rm extra make

* eth/tracers: make callFrame private

* eth/tracers: clean-up and comments

* eth/tracers: add license

* eth/tracers: rework the model a bit

* eth/tracers: move tracecall tests to subpackage

* cmd/geth: load native tracers

* eth/tracers: minor fix

* eth/tracers: impl stop

* eth/tracers: add native noop tracer

* renamings

Co-authored-by: Martin Holst Swende <martin@swende.se>

* eth/tracers: more renamings

* eth/tracers: make jstracer non-exported, avoid cast

* eth/tracers, core/vm: rename vm.Tracer to vm.EVMLogger for clarity

* eth/tracers: minor comment fix

* eth/tracers/testing: lint nitpicks

* core,eth: cancel evm on nativecalltracer stop

* Revert "core,eth: cancel evm on nativecalltracer stop"

This reverts commit 01bb908790a369c1bb9d3937df9325c6857bf855.

* eth/tracers: linter nits

* eth/tracers: fix output on err

Co-authored-by: Martin Holst Swende <martin@swende.se>
Signed-off-by: wenbiao <wenbiao.zheng@ambergroup.io>
    @s1na @holiman @rigsec
    2 people authored and rigsec committed Dec 10, 2021
    Configuration menu
    Copy the full SHA
    185c7bb View commit details
    Browse the repository at this point in the history

  15. eth/tracers: make native calltracer default (#23867) 

    Signed-off-by: wenbiao <wenbiao.zheng@ambergroup.io>
    @s1na @rigsec
    s1na authored and rigsec committed Dec 10, 2021
    Configuration menu
    Copy the full SHA
    6232c62 View commit details
    Browse the repository at this point in the history

  16. eth/tracers: package restructuring (#23857) 

    * eth/tracers: restructure tracer package

* core/vm/runtime: load js tracers

* eth/tracers: mv bigint js code to own file

* eth/tracers: add method docs for native tracers

* eth/tracers: minor doc fix

* core,eth: cancel evm on nativecalltracer stop

* core/vm: fix failing test

Co-authored-by: Sina Mahmoodi <itz.s1na@gmail.com>
Signed-off-by: wenbiao <wenbiao.zheng@ambergroup.io>
    @holiman @s1na @rigsec
    2 people authored and rigsec committed Dec 10, 2021
    Configuration menu
    Copy the full SHA
    827ed18 View commit details
    Browse the repository at this point in the history

  17. eth/tracers: ethapi.TransactionArgs was not merged 

    Signed-off-by: wenbiao <wenbiao.zheng@ambergroup.io>
    @rigsec
    rigsec committed Dec 10, 2021
    Configuration menu
    Copy the full SHA
    ba71d0b View commit details
    Browse the repository at this point in the history

  18. eth/tracers: fix the api_test with ErrInsufficientFunds to ErrInsuffi… 

    …cientFundsForTransfer

Signed-off-by: wenbiao <wenbiao.zheng@ambergroup.io>
    @rigsec
    rigsec committed Dec 10, 2021
    Configuration menu
    Copy the full SHA
    3eaba66 View commit details
    Browse the repository at this point in the history

  19. eth/tracers: check posa before statedb.Prepare in IntermiateRoots api 

    Signed-off-by: wenbiao <wenbiao.zheng@ambergroup.io>
    @rigsec
    rigsec committed Dec 10, 2021
    Configuration menu
    Copy the full SHA
    ce02ae5 View commit details
    Browse the repository at this point in the history

  20. eth/tracers: make js calltracer default, compatible with old version 

    Signed-off-by: wenbiao <wenbiao.zheng@ambergroup.io>
    @rigsec
    rigsec committed Dec 10, 2021
    Configuration menu
    Copy the full SHA
    85ef42c View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2021

  1. eth/tracers: fix the default callTrace name of callTracerJs 

    Signed-off-by: wenbiao <wenbiao.zheng@ambergroup.io>
    @rigsec
    rigsec committed Dec 12, 2021
    Configuration menu
    Copy the full SHA
    62a3bc2 View commit details
    Browse the repository at this point in the history

Commits on Dec 23, 2021

  1. Revert "eth/tracers: fix the default callTrace name of callTracerJs" 

    This reverts commit 62a3bc2.

Signed-off-by: wenbiao <wenbiao.zheng@ambergroup.io>
    @rigsec
    rigsec committed Dec 23, 2021
    Configuration menu
    Copy the full SHA
    c439458 View commit details
    Browse the repository at this point in the history

  2. Revert "eth/tracers: make js calltracer default, compatible with old … 

    …version"

This reverts commit 85ef42c.

Signed-off-by: wenbiao <wenbiao.zheng@ambergroup.io>
    @rigsec
    rigsec committed Dec 23, 2021
    Configuration menu
    Copy the full SHA
    85b8e4f View commit details
    Browse the repository at this point in the history

  3. eth/tracers: fix the variable race condition 

    Signed-off-by: wenbiao <wenbiao.zheng@ambergroup.io>
    @rigsec
    rigsec committed Dec 23, 2021
    Configuration menu
    Copy the full SHA
    7c84d70 View commit details
    Browse the repository at this point in the history