[R4R]fix state inconsistent when doing diffsync

[unclezoro]

Description

This PR is to fix a possible inconsistent state when doing diffsync. Since it is a syncing vulnerability which impact many clients, will release v1.1.7 especially for this patch.

Rationale

Diffsync will assemble the modification to MPT and snapshot according to the received difflayer and verify against the block header. In some cases(will disclose in future), the modification to MPT and snapshot is incorrect.

The problematic logic is apply too stick condition to modify the smart contract trie: https://github.com/binance-chain/bsc/blob/0b575443c43f47f2f50ed5549d2bcaf7ccc39ab4/core/state_processor.go#L256

Example

The current release, if you come across with bad block error with log message like: expected tx hash xx, get xx, nonce xx, to xx, value xx, gas xx, gasPrice xx, data xx. Here are some steps you can try to recover your node:

1. Stop The node.
2. Upgrade the binary to the release with this patch.
3. Start your node with --snapshot=false
4. Wait for few minutes(it depends on how fast your nodes are), until the block height is 128 higher than where it stopped.
5. Restart the node with --snapshot=true
6. The node will continue to sync and repair the corrupt data.

Changes

All the client that use diffsync is suggested to upgrade

Checks

It is been verified on Unittest and Testnet.

Related issues

No

[keefel]

LGTM

[liuyangc3]

In some cases(will disclose in future)...

Hi @guagualvcha Can you provide more info about this?