trie: reject deletions when verifying range proofs #667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 16, 2021
unclezoro
approved these changes
Dec 16, 2021
|
LGTM |
yutianwu
approved these changes
Dec 17, 2021
j75689
approved these changes
Dec 20, 2021
This was referenced Jan 26, 2022
Merged
keefel
added a commit
to keefel/bsc
that referenced
this pull request
Jun 6, 2022
Co-authored-by: Péter Szilágyi <peterke@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix "panic: deletion not supported" bug, cherry-pick from ethereum/go-ethereum#23960
Rationale
Return error when range contains deletion at
VerifyRangeProof, then when trie update, the deletion value won't get there, the panic won't be triggered.Example
Related issues
#475
#576