Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Infinite automatic build loop in Eclipse when overriding resources in POM #3220

Closed
wborn opened this issue May 30, 2019 · 7 comments
Closed

Infinite automatic build loop in Eclipse when overriding resources in POM #3220

wborn opened this issue May 30, 2019 · 7 comments
Assignees
@rotty3000
Labels
stale Stale issue or pull request

Comments

@wborn
Copy link
Contributor

wborn commented May 30, 2019 •
edited
Loading

After migrating openHAB from PDE to bnd (4.2.0) one of the remaining issues (https://github.com/openhab/openhab2-addons/issues/5554) is that Eclipse (2019-03) is in an infinite build loop when we enable "Project -> Build Automatically".

After investigating the issue it seems to be caused by the resource definitions in our Maven POMs:

After removing these customizations and updating the Maven projects in Eclipse the infinite loop is resolved. Do you think this loop is caused by an issue in bndtools?

I was able to reproduce the issue on the simpler bndtools/jpmcli project by adding a similar resources definition in wborn/jpmcli@d1efa61.
@wborn wborn mentioned this issue May 30, 2019
Closed
@IOOOTAlan
Copy link

Is this related to #3201?

@wborn
Copy link
Contributor Author

wborn commented May 30, 2019 •
edited
Loading

It looks like a different issue to me because it's about invoking Maven from the CLI and the POM in the example maggu2810/bnd-resolvebug project doesn't contain such resource definitions.

wborn added a commit to wborn/hello-world-bnd-3220 that referenced this issue May 30, 2019
@wborn
Add example for bndtools/bnd#3220
d3dcfe1 
Signed-off-by: Wouter Born <github@maindrain.net>
@wborn
Copy link
Contributor Author

wborn commented May 30, 2019

As a test I also checked if the issue can be reproduced on a simple Maven project (not using bnd) with such a resource definition. There is no build loop when using "Build Automatically" after importing this hello-world-bnd-3220 project in Eclipse. So it's probably not an Eclipse or m2e issue.

@rotty3000
Copy link
Contributor

rotty3000 commented May 30, 2019 •
edited
Loading

As a workaround, is the problem solved by using this approach instead?
in bnd:

-includeresource: -${.}/NOTICE, -${.}/*.xsd

(the leading - means don't fail/complain if resource is missing)

@wborn
Copy link
Contributor Author

wborn commented May 30, 2019

Thanks for the suggestion @rotty3000. I was already thinking about using such a workaround and so far it seems to work after testing it. 👍

@rotty3000
Copy link
Contributor

Great, as long as we can keep you moving forward! :)

wborn added a commit to wborn/openhab-core that referenced this issue May 30, 2019
@wborn
Use bnd for including resources to workaround infinite Eclipse builds
b6a845b 
When "Build Automatically" is enabled in Eclipse, the build never ends.
It seems there is a bnd issue with the way resources are defined in the reactor POM.
The workaround seems to be to include all resources using bnd.

See also:

* bndtools/bnd#3220
* https://github.com/openhab/openhab2-addons/issues/5554

Signed-off-by: Wouter Born <github@maindrain.net>
wborn added a commit to wborn/openhab-addons that referenced this issue May 30, 2019
@wborn
Use bnd for including resources to workaround infinite Eclipse builds
3191cd0 
When "Build Automatically" is enabled in Eclipse, the build never ends.
It seems there is a bnd issue with the way resources are defined in the reactor POM.
The workaround seems to be to include all resources using bnd.

See also:

* bndtools/bnd#3220
* https://github.com/openhab/openhab2-addons/issues/5554

Signed-off-by: Wouter Born <github@maindrain.net>
wborn added a commit to wborn/openhab-webui that referenced this issue May 30, 2019
@wborn
Use bnd for including resources to workaround infinite Eclipse builds
7b31412 
When "Build Automatically" is enabled in Eclipse, the build never ends.
It seems there is a bnd issue with the way resources are defined in the reactor POM.
The workaround seems to be to include all resources using bnd.

See also:

* bndtools/bnd#3220
* https://github.com/openhab/openhab2-addons/issues/5554

Signed-off-by: Wouter Born <github@maindrain.net>
wborn added a commit to wborn/openhab-webui that referenced this issue May 30, 2019
@wborn
Use bnd for including resources to workaround infinite Eclipse builds
fdb4b3c 
When "Build Automatically" is enabled in Eclipse, the build never ends.
It seems there is a bnd issue with the way resources are defined in the reactor POM.
The workaround seems to be to include all resources using bnd.

See also:

* bndtools/bnd#3220
* https://github.com/openhab/openhab2-addons/issues/5554

Signed-off-by: Wouter Born <github@maindrain.net>
This was referenced May 30, 2019
Merged
Merged
Merged
@bjhargrave bjhargrave added this to the Abeyance milestone May 31, 2019
davidgraeff pushed a commit to openhab/openhab-addons that referenced this issue May 31, 2019
@wborn
Use bnd for including resources to workaround infinite Eclipse builds (…
b9d025c 
…#5660)

When "Build Automatically" is enabled in Eclipse, the build never ends.
It seems there is a bnd issue with the way resources are defined in the reactor POM.
The workaround seems to be to include all resources using bnd.

See also:

* bndtools/bnd#3220
* https://github.com/openhab/openhab2-addons/issues/5554

Signed-off-by: Wouter Born <github@maindrain.net>
cweitkamp pushed a commit to openhab/openhab-core that referenced this issue Jun 1, 2019
@wborn @cweitkamp
Use bnd for including resources to workaround infinite Eclipse builds (…
7f5b8ca 
…#842)

When "Build Automatically" is enabled in Eclipse, the build never ends.
It seems there is a bnd issue with the way resources are defined in the reactor POM.
The workaround seems to be to include all resources using bnd.

See also:

* bndtools/bnd#3220
* https://github.com/openhab/openhab2-addons/issues/5554

Signed-off-by: Wouter Born <github@maindrain.net>
kaikreuzer pushed a commit to openhab/openhab-webui that referenced this issue Jun 1, 2019
@wborn @kaikreuzer
Use bnd for including resources to workaround infinite Eclipse builds (…
8112e09 
…#75)

When "Build Automatically" is enabled in Eclipse, the build never ends.
It seems there is a bnd issue with the way resources are defined in the reactor POM.
The workaround seems to be to include all resources using bnd.

See also:

* bndtools/bnd#3220
* https://github.com/openhab/openhab2-addons/issues/5554

Signed-off-by: Wouter Born <github@maindrain.net>
Pshatsillo pushed a commit to Pshatsillo/openhab-addons that referenced this issue Jun 19, 2019
@wborn @Pshatsillo
Use bnd for including resources to workaround infinite Eclipse builds (…
9053b3a 
…openhab#5660)

When "Build Automatically" is enabled in Eclipse, the build never ends.
It seems there is a bnd issue with the way resources are defined in the reactor POM.
The workaround seems to be to include all resources using bnd.

See also:

* bndtools/bnd#3220
* https://github.com/openhab/openhab2-addons/issues/5554

Signed-off-by: Wouter Born <github@maindrain.net>
Signed-off-by: Pshatsillo <pshatsillo@gmail.com>
ne0h pushed a commit to ne0h/openhab-addons that referenced this issue Sep 15, 2019
@wborn @ne0h
Use bnd for including resources to workaround infinite Eclipse builds (…
f7fa536 
…openhab#5660)

When "Build Automatically" is enabled in Eclipse, the build never ends.
It seems there is a bnd issue with the way resources are defined in the reactor POM.
The workaround seems to be to include all resources using bnd.

See also:

* bndtools/bnd#3220
* https://github.com/openhab/openhab2-addons/issues/5554

Signed-off-by: Wouter Born <github@maindrain.net>
Signed-off-by: Maximilian Hess <mail@ne0h.de>
tmrobert8 pushed a commit to tmrobert8/openhab-addons that referenced this issue Jan 21, 2020
@wborn @tmrobert8
Use bnd for including resources to workaround infinite Eclipse builds (…
f01db65 
…openhab#5660)

When "Build Automatically" is enabled in Eclipse, the build never ends.
It seems there is a bnd issue with the way resources are defined in the reactor POM.
The workaround seems to be to include all resources using bnd.

See also:

* bndtools/bnd#3220
* https://github.com/openhab/openhab2-addons/issues/5554

Signed-off-by: Wouter Born <github@maindrain.net>
Signed-off-by: Tim Roberts <timmarkroberts@gmail.com>
@bjhargrave bjhargrave removed this from the Abeyance milestone Jun 9, 2020
@bjhargrave bjhargrave added the stale Stale issue or pull request label Jun 9, 2020
@stale
Copy link

stale bot commented Jun 30, 2020

This issue has been automatically closed due to inactivity. If you can reproduce this on a recent version of Bnd/Bndtools or if you have a good use case for this feature, please feel free to reopen the issue with steps to reproduce, a quick explanation of your use case or a high-quality pull request.

@stale stale bot closed this as completed Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rotty3000 rotty3000

Labels
stale Stale issue or pull request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@rotty3000 @bjhargrave @wborn @IOOOTAlan