Cleans up the module names according to JPMS rules. #5802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--- Signed-off-by: Peter Kriens <Peter.Kriens@aQute.biz> Signed-off-by: Peter Kriens <Peter.Kriens@aQute.biz>
--- Signed-off-by: Peter Kriens <Peter.Kriens@aQute.biz> Signed-off-by: Peter Kriens <Peter.Kriens@aQute.biz>
ppkarwasz
approved these changes
Oct 10, 2023
| .anyMatch(e -> e.requires.equals("geronimo-jcdi_2.0_spec")) | ||
| .anyMatch(e -> e.requires.equals("geronimo.jcdi.2.0.spec")) |
There was a problem hiding this comment.
It seemed strange to me that Java uses geronimo.jcdi.2.0.spec as module name, which is invalid since 2 and 0 are not valid identifiers.
However jar -d -f generates the same identifier, so it is not a bug, but a feature:
piotr@bialykiel:~$ jar -d -f ~/.m2/repository/org/apache/geronimo/specs/geronimo-jcdi_2.0_spec/1.1/geronimo-jcdi_2.0_spec-1.1.jar
Unable to derive module descriptor for: /home/piotr/.m2/repository/org/apache/geronimo/specs/geronimo-jcdi_2.0_spec/1.1/geronimo-jcdi_2.0_spec-1.1.jar
geronimo.jcdi.2.0.spec: Invalid module name: '2' is not a Java identifier
There was a problem hiding this comment.
I had chat gpt verify the given algorithm and my (quite inventive!) code solution.
Thanks for checking. You will still make a PR for the other part?
There was a problem hiding this comment.
Sure, I'll submit a PR, although it might take some time, since I am swamped at work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #5792
This PR fixes the module name. Expect a PR from @ppkarwasz for the second part
Signed-off-by: Peter Kriens Peter.Kriens@aQute.biz