Add support for PropertyKeys, where these records pair the Processor/key #6073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--- Signed-off-by: Peter Kriens <Peter.Kriens@aQute.biz> Signed-off-by: Peter Kriens <Peter.Kriens@aQute.biz>
--- Signed-off-by: Peter Kriens <Peter.Kriens@aQute.biz> Signed-off-by: Peter Kriens <Peter.Kriens@aQute.biz>
--- Signed-off-by: Peter Kriens <Peter.Kriens@aQute.biz> Signed-off-by: Peter Kriens <Peter.Kriens@aQute.biz>
pkriens
force-pushed
the
feature/propertykey
branch
from
09edd88 to
1ac2cd7
Compare
--- Signed-off-by: Peter Kriens <Peter.Kriens@aQute.biz> Signed-off-by: Peter Kriens <Peter.Kriens@aQute.biz>
|
@chrisrueger I am now off, but if this has an ok build, feel free to merge tonight if you're moonlighting .... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@chrisrueger is working on editing the plugins. Since merged properties, the edit panes in the build.bnd
editor and the bnd.bnd editor are a bit of a mess.
This change in processor adds the concept of a PropertyKey, where the Property Key links the Processor that defines the property and the actual key. So a merged property is translated to a properly sorted set of ProperyKeys and can then be edited with the BndEditModel.
Unfortunately, the BndEditModel had no proper knowledge of the Processor. For this reason, a findProcessor method was added to Workspace and Project to find the a Processor that is properly linked with inheritance.
Signed-off-by: Peter Kriens Peter.Kriens@aQute.biz