Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: when using the current working directory, use . as the base and not the absolute path #109

Merged
merged 1 commit into from
Feb 22, 2024
Merged

feat: when using the current working directory, use . as the base and not the absolute path #109

merged 1 commit into from
Feb 22, 2024

Conversation

poliorcetics
Copy link
Contributor

This makes output much shorter and has not possiblity of failure too.

Example:

python-bindings -- ./python-bindings/Cargo.toml:
	pyo3_build_config

python-bindings -- /Users/poliorcetics/repos/work/int/main-project/rust-code/python-bindings/Cargo.toml:
	pyo3_build_config

@poliorcetics
feat: when using the current working directory, use . as the base a…
7765300 
…nd not the absolute path

This makes output much shorter and has not possiblity of failure too.
bnjbvr
bnjbvr approved these changes Feb 22, 2024
View reviewed changes
Copy link
Owner

@bnjbvr bnjbvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet, thanks!

@bnjbvr bnjbvr merged commit 9aa9978 into bnjbvr:main Feb 22, 2024
2 checks passed
@poliorcetics poliorcetics deleted the ab/push-qnzrlzotyqps branch February 22, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnjbvr bnjbvr bnjbvr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@poliorcetics @bnjbvr