Pin date-time (no import of AwareDatetime) #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lord-haffi
reviewed
Dec 7, 2023
There was a problem hiding this comment.
Vielleicht könntest du in der Testfunktion noch n assert am Ende reinklatschen. Sowas wie assert "datetime.datetime" in str(Angebot.model_fields["angebotsdatum"].annotation).
Btw, wenn du einen PR reviewed haben willst, solltest du ihn nicht auf "draft" stellen :) Bzw. wenn er review-fertig ist, dann auch auf GH unten den Button anklicken, damit der nicht mehr auf "draft" steht.
src/bo4e_generator/parser.py
Outdated
| @@ -52,11 +54,25 @@ class BO4EDataModel(data_model_types.data_model): # type: ignore[name-defined] | |||
| setattr(_Enum, "module_path", _module_path) | |||
| setattr(_Enum, "module_name", _module_name) | |||
|
|
|||
| class BO4EDataTypeManager(data_model_types.data_type_manager): # type: ignore[name-defined] | |||
| """Override the data type manager to use create the namespace. -> ensures desired date-time type""" | |||
There was a problem hiding this comment.
Suggested change
| """Override the data type manager to use create the namespace. -> ensures desired date-time type""" | |
| """ | |
| Override the data type manager to prevent the code generator from using the `AwareDateTime` type | |
| featured in pydantic v2. Instead, the standard datetime type will be used. | |
| """ |
lord-haffi
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.