Merge 145aa2b into fbb1077

boa-dev · Oct 20, 2020 · cad9698 · cad9698
2 parents fbb1077 + 145aa2b
commit cad9698
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/boa/src/object/internal_methods.rs b/boa/src/object/internal_methods.rs
@@ -83,8 +83,9 @@ impl GcObject {
                 parent.get_field(key.clone())
             }
             Some(ref desc) => match desc {
-                PropertyDescriptor::Accessor(_) => todo!(),
                 PropertyDescriptor::Data(desc) => desc.value(),
+                // TODO: Add accessors
+                PropertyDescriptor::Accessor(_) => Value::undefined(),
             },
         }
     }
@@ -118,7 +119,8 @@ impl GcObject {
                 let desc = DataDescriptor::new(val, own_desc.attributes()).into();
                 self.define_own_property(key, desc)
             }
-            PropertyDescriptor::Accessor(_) => todo!(),
+            // TODO: Add accessors
+            PropertyDescriptor::Accessor(_) => false,
         }
     }
 

diff --git a/boa/src/value/mod.rs b/boa/src/value/mod.rs
@@ -456,7 +456,8 @@ impl Value {
         let key = key.into();
         match self.get_property(key) {
             Some(ref desc) => match desc {
-                PropertyDescriptor::Accessor(_) => todo!("property accessor descriptors"),
+                // TODO: Add accessors
+                PropertyDescriptor::Accessor(_) => Value::undefined(),
                 PropertyDescriptor::Data(desc) => desc.value(),
             },
             None => Value::undefined(),