Add documentation

Rename some fields for clarity Add some performance improvements
boa-dev · Aug 8, 2021 · f800db8 · f800db8
1 parent b5114a3
commit f800db8
Show file tree

Hide file tree

Showing 8 changed files with 215 additions and 56 deletions.
diff --git a/boa/src/bytecompiler.rs b/boa/src/bytecompiler.rs
@@ -589,7 +589,7 @@ impl ByteCompiler {
             Node::VarDeclList(list) => {
                 for decl in list.as_ref() {
                     match decl {
-                        Declaration::Identifier(ident, _) => {
+                        Declaration::Identifier { ident, .. } => {
                             let index = self.get_or_insert_name(ident.as_ref());
                             self.emit(Opcode::DefVar, &[index]);
 
@@ -615,7 +615,7 @@ impl ByteCompiler {
             Node::LetDeclList(list) => {
                 for decl in list.as_ref() {
                     match decl {
-                        Declaration::Identifier(ident, _) => {
+                        Declaration::Identifier { ident, .. } => {
                             let index = self.get_or_insert_name(ident.as_ref());
                             self.emit(Opcode::DefLet, &[index]);
 
@@ -641,7 +641,7 @@ impl ByteCompiler {
             Node::ConstDeclList(list) => {
                 for decl in list.as_ref() {
                     match decl {
-                        Declaration::Identifier(ident, _) => {
+                        Declaration::Identifier { ident, .. } => {
                             let index = self.get_or_insert_name(ident.as_ref());
                             self.emit(Opcode::DefConst, &[index]);
 

diff --git a/boa/src/object/gcobject.rs b/boa/src/object/gcobject.rs
@@ -923,7 +923,9 @@ impl GcObject {
         }
 
         // 4. Let from be ! ToObject(source).
-        let from = source.to_object(context)?;
+        let from = source
+            .to_object(context)
+            .expect("function ToObject should never complete abruptly here");
 
         // 5. Let keys be ? from.[[OwnPropertyKeys]]().
         // 6. For each element nextKey of keys, do
@@ -937,7 +939,8 @@ impl GcObject {
                 // i. If SameValue(e, nextKey) is true, then
                 if *e == key {
                     // 1. Set excluded to true.
-                    excluded = true
+                    excluded = true;
+                    break;
                 }
             }
             // c. If excluded is false, then
@@ -956,7 +959,7 @@ impl GcObject {
                             key,
                             DataDescriptor::new(prop_value, Attribute::all()),
                             context,
-                        )?;
+                        ).expect("function CreateDataPropertyOrThrow should never complete abruptly here");
                     }
                 }
             }