do not expose the matcher beyong Regexp

src/lib/builtins/regexp.rs

@@ -1,3 +1,4 @@
+use std::borrow::Cow;
 use std::ops::Deref;
 
 use gc::Gc;
@@ -16,7 +17,7 @@ use crate::{
 #[derive(Debug)]
 pub struct RegExp {
     /// Regex matcher.
-    pub matcher: Regex,
+    matcher: Regex,
     /// Update last_index, set if global or sticky flags are set.
     use_last_index: bool,
     /// String of parsed flags.
@@ -37,6 +38,12 @@ pub struct RegExp {
 
 impl InternalState for RegExp {}
 
+impl RegExp {
+    pub fn replace_all<'t>(&self, text: &'t str, rep: &str) -> Cow<'t, str> {
+        self.matcher.replace_all(text, rep)
+    }
+}
+
 fn get_argument<T: FromValue>(args: &[Value], idx: usize) -> Result<T, Value> {
     match args.get(idx) {
         Some(arg) => from_value(arg.clone()).map_err(to_value),

src/lib/builtins/string.rs

@@ -752,7 +752,7 @@ pub fn replace(this: &Value, args: &[Value], ctx: &mut Interpreter) -> ResultVal
         Ok(to_value(result_str))
     } else {
         pattern.with_internal_state_ref(|pattern_re: &RegExp| {
-            let result_str = pattern_re.matcher.replace_all(this_str, replacement_str);
+            let result_str = pattern_re.replace_all(this_str, replacement_str);
             Ok(to_value(result_str.into_owned()))
         })
     }